Skip to content

Replace quotation marks around template variables with double quotes#1301

Open
sigma7863 wants to merge 5 commits intoobsidianmd:masterfrom
sigma7863:ja-fix-quotation-marks-patch3
Open

Replace quotation marks around template variables with double quotes#1301
sigma7863 wants to merge 5 commits intoobsidianmd:masterfrom
sigma7863:ja-fix-quotation-marks-patch3

Conversation

@sigma7863
Copy link
Copy Markdown
Contributor

Summary

Replace Japanese-style quotes (「」) with double quotes (").

Changes

  • Replaced all Japanese-style quotes with double quotes

Scope

  • Only quotation mark replacement
  • No changes to meaning

Notes

If 「」 is preferred, I can revert this change.

Copilot AI review requested due to automatic review settings April 7, 2026 05:43
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Japanese localization strings by standardizing quotation marks, replacing Japanese-style corner brackets (「」) with double quotes (").

Changes:

  • Replaced Japanese-style quotes with double quotes in multiple translation= entries in translations/ja.txt.
  • Updated quoted placeholders/menu labels (e.g., {{plugin}}, {{subpath}}) to use " consistently with the PR intent.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 96 to 100

[setting.editor.option-properties-in-document-description]
original=Choose how properties are displayed at the top of notes. Select “source” to show properties as raw YAML.
translation=エディタ内でのプロパティの表示方法を選択してください。プロパティをYAMLとして表示する場合にはソースを選択してください。
translation=エディタ内でのプロパティの表示方法を選択してください。プロパティをYAMLとして表示する場合には "ソース" を選択してください。

Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description says all Japanese-style quotes (「」) were replaced, but translations/ja.txt still contains at least one occurrence (e.g. line ~6851: 「設定」 -> 「コアプラグイン」). Either update the remaining strings to match this change or adjust the PR description/scope accordingly.

Copilot uses AI. Check for mistakes.
@lishid
Copy link
Copy Markdown
Contributor

lishid commented Apr 10, 2026

I think it would be preferable to keep this as it previously was.

Updated translations for various settings and messages to improve clarity and consistency in Japanese.
@sigma7863
Copy link
Copy Markdown
Contributor Author

I think it would be preferable to keep this as it previously was.

Updated the translation to use double quotes (") only around placeholder variables such as {{...}}. Other parts of the text remain unchanged.

@sigma7863 sigma7863 changed the title Replace Japanese quotes with double quotes Replace quotation marks around template variables with double quotes Apr 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants