Invert deaths_per_min benchmark percentile - #2978
Merged
Merged
Conversation
howardchung
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2970: deaths_per_min is the one benchmark where a lower value is better, but its percentile is computed like the others (share of players at or below your value), so right now a 12-death game shows as ~67th percentile and gets colored as great on the match page, while a deathless one shows ~2% in red. This computes it as the share of players with a higher value instead.
You can see it on any current match, e.g. 8754463676: the deathless player is the red 0.91% in the DPM column.