Refine JSON implementation for mutability, type safety, and performance - #248
Merged
Conversation
AlexNachbaur
commented
Aug 20, 2025
AlexNachbaur
commented
Contributor
- Previous implementation wasn't mutable, didn't persist its underlying value, and had a clunky developer experience
- Working with WebAuthn, IDX, and JWT generation necessitates JSON mutability
- Relocates JSON and concurrency utility types to separate targets, to streamline maintainability and testing
There was a problem hiding this comment.
Pull Request Overview
This PR significantly refines the JSON implementation to improve mutability, type safety, and performance. The changes introduce a new mutable JSON system with proper copy-on-write semantics, relocate utility types to separate targets, and streamline the overall codebase architecture.
- Introduces a new JSON module with full mutability support and proper copy-on-write patterns
- Moves common utility types (CopyOnWrite, ExpressionUtilities, etc.) to a separate CommonSupport target
- Updates all JSON-related types to use the new JSON implementation instead of the previous immutable approach
Reviewed Changes
Copilot reviewed 107 out of 112 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| Sources/JSON/ | Complete new JSON module implementation with mutable values and type safety |
| Sources/CommonSupport/ | New target containing utility types previously in AuthFoundation |
| Tests/JSONTests/ | Comprehensive test suite for the new JSON implementation |
| Various AuthFoundation files | Updated to use new JSON types and CommonSupport utilities |
| Various test files | Updated imports and test code to work with new JSON API |
Files not reviewed (1)
- OktaClient.xcworkspace/contents.xcworkspacedata: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
AlexNachbaur
force-pushed
the
OKTA-998746-mutableJSON
branch
from
August 20, 2025 21:24
71c04a4 to
042013a
Compare
AlexNachbaur
requested review from
FeiChen-okta,
IldarAbdullin-okta and
jaredperreault-okta
August 26, 2025 17:00
FeiChen-okta
previously approved these changes
Aug 28, 2025
AlexNachbaur
force-pushed
the
OKTA-998746-mutableJSON
branch
from
September 18, 2025 01:48
d5c2e41 to
e6725d9
Compare
* Previous implementation wasn't mutable, didn't persist its underlying value, and had a clunky developer experience * Working with WebAuthn, IDX, and JWT generation necessitates JSON mutability * Relocates JSON and concurrency utility types to separate targets, to streamline maintainability and testing
AlexNachbaur
force-pushed
the
OKTA-998746-mutableJSON
branch
from
September 24, 2025 23:32
e6725d9 to
4a811b4
Compare
AlexNachbaur
changed the base branch from
feature-dpop
to
relocate-json-libs
September 25, 2025 01:18
AlexNachbaur
force-pushed
the
relocate-json-libs
branch
from
October 2, 2025 17:51
0aed5f8 to
ba81f99
Compare
AlexNachbaur
dismissed
IldarAbdullin-okta’s stale review
October 3, 2025 15:42
The base branch was changed.
AlexNachbaur
requested review from
FeiChen-okta,
IldarAbdullin-okta and
Copilot
October 3, 2025 17:43
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 92 out of 92 changed files in this pull request and generated 5 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
FeiChen-okta
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.