🌱 chore: Bump Flower to 1.32.1 - #123
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
✅ Files skipped from review due to trivial changes (4)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughThis PR updates Flower 1.26.1 references to 1.32.1 in controller build instructions, app images, Helm chart metadata and values, and Python dependency constraints across federated-learning-controller and flower-addon. ChangesFlower Version Bump
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
flower-addon/cifar10/pyproject.toml (1)
11-11: 🗄️ Data Integrity & Integration | 🔵 Trivial | ⚡ Quick winConsider pinning an upper bound alongside the floor constraint.
flwr>=1.32.1is open-ended, so a future major/minor flwr release could be resolved by pip while the Containerfile and Makefile pin thesuperexec/superlink/supernodeimages to the exact1.32.1tag. Flower's own changelog notes that AppIo communication now enforces matching major.minor releases between components, so a client library newer than the pinned server images could break compatibility at runtime.Consider constraining to the same minor series, e.g.
flwr>=1.32.1,<1.33.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@flower-addon/cifar10/pyproject.toml` at line 11, The flwr dependency in pyproject.toml is only lower-bounded, which can allow an incompatible newer release to be installed against the pinned 1.32.1 container images. Update the dependency spec in the pyproject.toml entry for flwr to keep the current floor while adding an upper bound that stays within the same minor series, so the client library remains compatible with the superexec/superlink/supernode images.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@flower-addon/cifar10/pyproject.toml`:
- Line 11: The flwr dependency in pyproject.toml is only lower-bounded, which
can allow an incompatible newer release to be installed against the pinned
1.32.1 container images. Update the dependency spec in the pyproject.toml entry
for flwr to keep the current floor while adding an upper bound that stays within
the same minor series, so the client library remains compatible with the
superexec/superlink/supernode images.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 2b4ffa67-d7ed-44e8-b5b4-5fa5cbe2fb02
📒 Files selected for processing (8)
federated-learning-controller/README.mdfederated-learning-controller/examples/flower/app-torch/Dockerfilefederated-learning-controller/examples/flower/app-torch/pyproject.tomlflower-addon/Makefileflower-addon/charts/flower-addon/Chart.yamlflower-addon/charts/flower-addon/values.yamlflower-addon/cifar10/Containerfileflower-addon/cifar10/pyproject.toml
mikeshng
left a comment
mikeshng
left a comment
There was a problem hiding this comment.
@chongshenng thank you for your contribution!
Could you please amend your commit with a sign-off? ie:
git commit -s --amend
git push -f ....
I will fix the e2e issue.
Signed-off-by: Chong Shen Ng <chong.shen@flower.ai>
91fcd65 to
fddda04
Compare
|
Awesome, thanks @mikeshng. I've signed-off my commit as requested. Please let me know if any step is missing on my end. |
mikeshng
left a comment
mikeshng
left a comment
There was a problem hiding this comment.
/approve
/lgtm
Thank you for this contribution!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chongshenng, mikeshng The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mikeshng
left a comment
mikeshng
left a comment
There was a problem hiding this comment.
@chongshenng I thought the unit test is just being flaky but after a few retries, it's still failing at the same spot. I am suspecting there were some lib/api changes from the flower version bump so this PR might need to make some code adjustments. Let me know if you think otherwise. Thanks!
|
Interesting, let me take a look later this week. As far as I’m aware the
Flower APIs have not changed much since that version, but I could be wrong.
…On Mon, 6 Jul 2026 at 9:09 pm, Mike Ng ***@***.***> wrote:
***@***.**** commented on this pull request.
@chongshenng <https://github.com/chongshenng> I thought the unit test is
just being flaky but after a few retries, it's still failing at the same
spot. I am suspecting there were some lib/api changes from the flower
version bump so this PR might need to make some code adjustments. Let me
know if you think otherwise. Thanks!
—
Reply to this email directly, view it on GitHub
<#123?email_source=notifications&email_token=AHEQKSXFGLBBM6QT2CYSOFL5DQBOFA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINRTHEZTQMJXGYYKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#pullrequestreview-4639381760>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHEQKSXJ5H4VITXCVQCOKF35DQBOFAVCNFSNUABFKJSXA33TNF2G64TZHM2TIMZUGA2DMOBUHNEXG43VMU5TIOBQGQYDSNRSHA4KC5QC>
.
You are receiving this because you were mentioned.Message ID:
<open-cluster-management-io/addon-contrib/pull/123/review/4639381760@
github.com>
|
2 participants
Summary
Flower
1.32.1has been recently released. This PR bumps the versions for allflwr-related dependencies.Related issue(s)
Fixes #
Summary by CodeRabbit
1.26.1to1.32.1across example apps and add-on tooling.flwr>=1.32.1,<2in the affected reference apps.1.32.1for the deployed components’ image tags.1.32.1).