Skip to content

ui updates to reflect ord-app - #171

Closed
alli-linhart wants to merge 3 commits into
open-reaction-database:mainfrom
ND-DAC-DOME:alinny
Closed

ui updates to reflect ord-app#171
alli-linhart wants to merge 3 commits into
open-reaction-database:mainfrom
ND-DAC-DOME:alinny

Conversation

@alli-linhart

Copy link
Copy Markdown

No description provided.

@skearnes

Copy link
Copy Markdown
Member

Hi @alli-linhart and @mikennel; we recently merged #176 --- let me know if there's more you want to do here.

@skearnes

Copy link
Copy Markdown
Member

Heads up — this PR's base no longer exists in the form it expects. main is now the React + TypeScript + Vite port from #179, and every file this PR touches was either deleted or renamed during that migration:

  • The 7 .vue components (App, EntityTable, HeaderNav, ReactionCard, About, MainSearch, SearchOptions) were replaced by .tsx equivalents — there's no <style lang="sass"> block left for the styling diff to land on.
  • app/src/styles/{vars,table,tabs}.sass were renamed to .scss and migrated to @use syntax.
  • app/vue.config.js was replaced by app/vite.config.ts.

So a straight rebase / merge isn't possible — GitHub shows mergeable: CONFLICTING and there's no path for git to reconcile a Sass+Pug diff against SCSS+JSX targets that don't exist.

The intent of the PR is still very welcome though. Looking at it, there are two stacked pieces:

  1. The design-token system added to vars.sass (semantic tokens like $color-primary, $color-border-1, plus the Mantine-style color ramp).
  2. Component-level applications of those tokens (replacing hard-coded #0d6efd / $lightgrey / $medgrey), plus the small UX tweaks (target="_blank" on Contribute/Docs, button hover, EntityTable search-area card styling).

Both are portable to the React + SCSS world — happy to either help land it as a fresh branch on top of main, or close this one out and reopen against the new structure. What works best for you?

🤖 Generated with Claude Code

@skearnes skearnes closed this Jun 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants