Skip to content

Replace Mypy with Pyrefly in lint workflow#59

Open
asukaminato0721 wants to merge 2 commits into
mainfrom
pyrefly
Open

Replace Mypy with Pyrefly in lint workflow#59
asukaminato0721 wants to merge 2 commits into
mainfrom
pyrefly

Conversation

@asukaminato0721

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings December 29, 2025 19:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR replaces the type checker in the lint workflow by changing from ty to pyrefly. The change updates the tool installation and execution command while maintaining the same workflow structure.

Key Changes

  • Updated the type checking tool from ty to pyrefly in the lint workflow

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


- name: Run Mypy
run: uv tool install ty && ty check .
run: uv tool install pyrefly && pyrefly check .

Copilot AI Dec 29, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pyproject.toml file still contains mypy configuration under [tool.mypy] (lines 17-28). If pyrefly is replacing mypy, either remove the mypy configuration or add equivalent pyrefly configuration if needed. If pyrefly is compatible with mypy configuration, this should be documented or the configuration section should be renamed accordingly.

Suggested change
run: uv tool install pyrefly && pyrefly check .
run: uvx mypy .

Copilot uses AI. Check for mistakes.
@@ -28,4 +28,4 @@ jobs:
run: uvx ruff check --output-format=github . && uvx ruff format --check

- name: Run Mypy

Copilot AI Dec 29, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The step name "Run Mypy" is inconsistent with the actual tool being run (pyrefly). The step name should be updated to match the tool being executed.

Suggested change
- name: Run Mypy
- name: Run Pyrefly

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants