Skip to content

Replace Mypy with Pyrefly in lint workflow #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asukaminato0721 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Replace Mypy with Pyrefly in lint workflow #59

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a851889
Replace Mypy with Pyrefly in lint workflow
asukaminato0721 Oct 31, 2025
0345a7c
Merge branch 'main' into pyrefly
asukaminato0721 Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,4 @@ jobs:
run: uvx ruff check --output-format=github . && uvx ruff format --check

- name: Run Mypy

Copilot AI Dec 29, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The step name "Run Mypy" is inconsistent with the actual tool being run (pyrefly). The step name should be updated to match the tool being executed.

Suggested change
- name: Run Mypy
- name: Run Pyrefly

Copilot uses AI. Check for mistakes.
run: uv tool install ty && ty check .
run: uv tool install pyrefly && pyrefly check .

Copilot AI Dec 29, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pyproject.toml file still contains mypy configuration under [tool.mypy] (lines 17-28). If pyrefly is replacing mypy, either remove the mypy configuration or add equivalent pyrefly configuration if needed. If pyrefly is compatible with mypy configuration, this should be documented or the configuration section should be renamed accordingly.

Suggested change
run: uv tool install pyrefly && pyrefly check .
run: uvx mypy .

Copilot uses AI. Check for mistakes.
Loading