feat: add support for identity compression algorithm in confighttp#15656
Open
farhan11166 wants to merge 1 commit into
Open
feat: add support for identity compression algorithm in confighttp#15656farhan11166 wants to merge 1 commit into
farhan11166 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Per RFC 7231 3.1.2.2,
Content-Encoding: identityis a valid header value that signifies no encoding/compression was used.The
httpContentDecompressorpreviously rejected payloads withContent-Encoding: identitywith a400 Bad Requestbecause"identity"was not registered in the available decoders. This PR fixes the issue by mapping"identity"to act as a pass-through (identical to"") whenever uncompressed payloads are allowed.This also resolves a documented
// BUG:in thecompression_test.gosuite.Link to tracking issue
Fixes #
Testing
Mixed_Identity_ShouldAccepttest case incompression_test.gowhich previously expected a400 Bad Request(marked as a BUG) to correctly expect200 OK.go test ./...inconfig/confighttpand verified all tests pass.Documentation
None needed.
Authorship