Skip to content

feat: add support for identity compression algorithm in confighttp #15656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
farhan11166 wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −1
Open

feat: add support for identity compression algorithm in confighttp #15656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbf3f83
feat: add support for identity compression algorithm in confighttp
farhan11166 Jul 24, 2026
9b1259c
Merge branch 'main' into pr-identity-fix
farhan11166 Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions config/confighttp/compression.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,10 @@ var availableDecoders = map[string]func(body io.ReadCloser) (io.ReadCloser, erro
// Not a compressed payload. Nothing to do.
return nil, nil
},
"identity": func(io.ReadCloser) (io.ReadCloser, error) {
// Per RFC 7231 §3.1.2.2, "identity" means no encoding.
return nil, nil
},
"gzip": func(body io.ReadCloser) (io.ReadCloser, error) {
gr, err := gzip.NewReader(body)
if err != nil {
Expand Down Expand Up @@ -249,6 +253,9 @@ func httpContentDecompressor(h http.Handler, maxRequestBodySize int64, eh func(w
for _, dec := range enableDecoders {
enabled[dec] = availableDecoders[dec]

if dec == "" {
enabled["identity"] = availableDecoders["identity"]
}
if dec == "deflate" {
enabled["deflate"] = availableDecoders["zlib"]
}
Expand Down
2 changes: 1 addition & 1 deletion config/confighttp/compression_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,7 +638,7 @@ func TestCompressionAlgorithmsEdgeCases(t *testing.T) {
compressionAlgorithms: []string{"", "gzip", "zstd"},
contentEncoding: "identity",
body: testBody,
wantStatus: http.StatusBadRequest, // BUG: should be http.StatusOK
wantStatus: http.StatusOK, // BUG: should be http.StatusOK
},
{
name: "Mixed_Snappy_Rejected",
Expand Down