fix(msix): default PublisherDisplayName to the registered Store name - #1043
Conversation
The Microsoft Store rejects the package when Properties/PublisherDisplayName
does not match the registered publisher display name, and (unlike the Identity
Name/Publisher, which the Store remaps on ingestion) it is validated strictly.
The release workflow runs build-msix.ps1 with no arguments, so it used the
old default "GeoLibre", which failed validation ("doesn't match your publisher
display name: Open Geospatial Solutions").
Default PublisherDisplayName to "Open Geospatial Solutions" so the CI-built
MSIX passes Store validation, and update the packaging README table to match.
✅ Deploy Preview for geolibre-app ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Warning Review limit reached
Next review available in: 3 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR fixes Microsoft Store MSIX validation failures by aligning the default Properties/PublisherDisplayName in the MSIX manifest with the publisher display name registered in Partner Center, ensuring that Store uploads succeed even when the build script is run with no arguments (as in the release workflow).
Changes:
- Update
build-msix.ps1default-PublisherDisplayNametoOpen Geospatial Solutionsand document why the Store requires an exact match. - Update the MSIX packaging README parameter table to reflect the corrected default and clarify that the Store does not remap this field.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packaging/msix/README.md | Updates documentation so the -PublisherDisplayName default/requirements match Microsoft Store expectations. |
| packaging/msix/build-msix.ps1 | Changes the default PublisherDisplayName used in the generated Appx manifest to the Partner Center registered value, with clarifying comments. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
⚡ Cloudflare Pages preview
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| # against the registered publisher display name, so it must match Partner | ||
| # Center exactly ("Open Geospatial Solutions"). Unlike Identity Name/Publisher, | ||
| # the Store does not remap it on ingestion. | ||
| [string] $PublisherDisplayName = "Open Geospatial Solutions", |
There was a problem hiding this comment.
Medium confidence: this default is shared by both build targets described in the README — the self-signed/winget MSIX built by release.yml (defaults: Publisher = "CN=GeoLibre") and the manually-built Microsoft Store MSIX (Publisher overridden to the Partner Center seller GUID).
Before this change both Publisher and PublisherDisplayName defaulted to "GeoLibre", so the self-signed/winget artifact was internally consistent. After this change, the default release.yml build will embed Publisher="CN=GeoLibre" alongside PublisherDisplayName="Open Geospatial Solutions" — a mismatch between the signing identity and the displayed publisher name for the winget/direct-download package, which didn't exist before.
If release.yml's default build is in fact the same artifact being uploaded to the Store (as the PR description implies — no -Publisher/-Name override is passed there either), it may be worth also defaulting -Publisher/-Name to the Store identity, or conversely keeping PublisherDisplayName branching per target, so the self-signed build's Identity and Properties/PublisherDisplayName stay consistent with each other.
Code reviewThis is a small, low-risk config-default change (2 files, +6/-2), so findings are limited. Bugs
Security
Performance
Quality
CLAUDE.md
|
Problem
The v1.9.0 Microsoft Store upload failed validation:
The release workflow (
release.yml) runspackaging/msix/build-msix.ps1with no arguments, so the package used the defaultPublisherDisplayName = "GeoLibre". The Store validatesProperties/PublisherDisplayNamestrictly against the registered publisher name and, unlike theIdentityName/Publisher(which it remaps on ingestion), does not rewrite it. That is why this was the only blocking error.Fix
-PublisherDisplayNameto"Open Geospatial Solutions"(the registered Partner Center value, already documented in the packaging README).The
runFullTrustwarning in the same report is expected for a Tauri desktop app and only needs one-time capability approval in Partner Center; no code change required.Note
This corrects future MSIX builds. The already-uploaded v1.9.0 MSIX needs to be rebuilt (re-run the Windows release job, or rebuild locally with the corrected default) to produce an uploadable package.