Skip to content

fix(msix): default PublisherDisplayName to the registered Store name #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
giswqs merged 1 commit into from
Jul 1, 2026
Merged

fix(msix): default PublisherDisplayName to the registered Store name #1043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packaging/msix/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ pwsh ./packaging/msix/build-msix.ps1 `
| --- | --- | --- |
| `-Name` | Tauri identifier (`org.geolibre.desktop`) | Must be the reserved `Package/Identity/Name` |
| `-Publisher` | `CN=GeoLibre` | Must be your seller `CN=<GUID>` |
| `-PublisherDisplayName` | `GeoLibre` | Must match your publisher display name |
| `-PublisherDisplayName` | `Open Geospatial Solutions` | Must match your publisher display name exactly; the Store does not remap it |
| `-DisplayName` | Tauri `productName` (`GeoLibre Desktop`) | `Properties/DisplayName` must be a **reserved** name |
| `-Language` | `en-us` | Every MSIX must declare a language |

Expand Down
6 changes: 5 additions & 1 deletion packaging/msix/build-msix.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,11 @@ param(
[ValidateSet("x64", "x86", "arm64", "arm", "neutral")]
[string] $Architecture = "x64",
[string] $Publisher = "CN=GeoLibre",
[string] $PublisherDisplayName = "GeoLibre",
# Properties/PublisherDisplayName. The Microsoft Store validates this strictly
# against the registered publisher display name, so it must match Partner
# Center exactly ("Open Geospatial Solutions"). Unlike Identity Name/Publisher,
# the Store does not remap it on ingestion.
[string] $PublisherDisplayName = "Open Geospatial Solutions",

@github-actions github-actions Bot Jul 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Medium confidence: this default is shared by both build targets described in the README — the self-signed/winget MSIX built by release.yml (defaults: Publisher = "CN=GeoLibre") and the manually-built Microsoft Store MSIX (Publisher overridden to the Partner Center seller GUID).

Before this change both Publisher and PublisherDisplayName defaulted to "GeoLibre", so the self-signed/winget artifact was internally consistent. After this change, the default release.yml build will embed Publisher="CN=GeoLibre" alongside PublisherDisplayName="Open Geospatial Solutions" — a mismatch between the signing identity and the displayed publisher name for the winget/direct-download package, which didn't exist before.

If release.yml's default build is in fact the same artifact being uploaded to the Store (as the PR description implies — no -Publisher/-Name override is passed there either), it may be worth also defaulting -Publisher/-Name to the Store identity, or conversely keeping PublisherDisplayName branching per target, so the self-signed build's Identity and Properties/PublisherDisplayName stay consistent with each other.

# Identity Name. Defaults to the Tauri identifier; override with the reserved
# package name from Partner Center (Product Identity) for a Microsoft Store
# submission.
Expand Down
Loading