docs: link hero screenshots and move media to assets.geolibre.app - #1792
Conversation
The hero showed a single map view. A 3D building example alongside it gives a fuller first impression of what the app can render. Both images now come from the assets.geolibre.app host.
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThe homepage now shows linked GeoLibre and NYC buildings figures. CSS places them in a grid. Documentation media uses ChangesDocumentation and asset references
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code reviewReviewed the two changed files ( Bugs: None found. The Security: None found. No injected content, scripts, or unsanitized input; just two static Performance: No issues — this only adds one additional static image reference. Quality: Minor, non-blocking observation (low confidence, not worth blocking on): the PR switches both hero images to CLAUDE.md: Not applicable — the CSP/tile-host allowlist convention in CLAUDE.md concerns the Tauri desktop app's map/tile hosts, not the mkdocs documentation site, so no allowlist update is needed for the new image host. No inline comments posted — the change is small, well-scoped, and I didn't find anything rising to reportable severity. |
The screenshot is a real published project, so clicking it should open the live map rather than being a static image.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
🔍 Cloudflare PR preview
|
Matches the NYC screenshot next to it, so both hero images open the live project they show.
🔍 GitHub Pages PR preview
Note GitHub Pages built this preview successfully, but its serving edge returned HTTP 403 when checked. The links may still be propagating. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| </figure> | ||
| <figure> | ||
| <a href="https://share.geolibre.app/giswqs/nyc-buildings-and-subways" title="Open the New York City buildings and subways map"> | ||
| <img src="https://assets.geolibre.app/images/nyc-buildings.webp" alt="Manhattan buildings extruded in 3D and colored by construction era, with MTA subway lines and stations and an auto-generated legend"> |
There was a problem hiding this comment.
Low confidence, quality/process: nyc-buildings.webp is a new addition under assets.geolibre.app/images/ (the existing copy referenced elsewhere in the docs, e.g. docs/demos.md, still lives at files.opengeos.org/nyc-buildings.webp). Per docs/contributing.md, publishing to assets.geolibre.app requires pushing the file to the separate opengeos/geolibre-assets repo first. Since zensical build --strict only validates internal links/nav, not external image URLs, if that mirror hasn't been pushed yet this ships with a silently broken hero image. Worth confirming the asset is live (the PR's own test-plan checkbox for this is still unchecked) before merging.
| <figure> | ||
| <a href="https://share.geolibre.app/giswqs/3d-tiles" title="Open the 3D Tiles map"> | ||
| <img src="https://assets.geolibre.app/images/GeoLibre-demo.webp" alt="GeoLibre map interface showing the GIS workspace"> | ||
| </a> | ||
| </figure> | ||
| <figure> | ||
| <a href="https://share.geolibre.app/giswqs/nyc-buildings-and-subways" title="Open the New York City buildings and subways map"> | ||
| <img src="https://assets.geolibre.app/images/nyc-buildings.webp" alt="Manhattan buildings extruded in 3D and colored by construction era, with MTA subway lines and stations and an auto-generated legend"> | ||
| </a> | ||
| </figure> |
There was a problem hiding this comment.
Very low confidence, quality/a11y nit: both hero images are now wrapped in <a> links with a title attribute describing the destination ("Open the 3D Tiles map" / "Open the New York City buildings and subways map"), but no visible/link text. Screen readers typically derive a link's accessible name from the child <img alt> (which describes the image content, e.g. "GeoLibre map interface showing the GIS workspace") rather than reliably announcing title. Consider an aria-label on the <a> (or reusing the title text as the accessible name) if the destination context should be conveyed to AT users — optional, not blocking.
Code reviewThis is a small, low-risk docs/CSS change (hero section now shows two screenshots, images re-hosted to Bugs: None found. Security: None found. No secrets, injection, or unsafe input handling — this is static markdown/CSS. Performance: None found. Two images instead of one is a negligible cost for a landing page. Quality:
CLAUDE.md: No violations. The image-hosting change follows |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/index.md`:
- Line 70: Revise the toolbox description around the “1,000+ geoprocessing
tools” claim to distinguish tools that run client-side in WebAssembly from
vector and raster operations requiring GeoPandas or rasterio sidecars. Remove
the blanket “no Python sidecar” and universal platform-support claims unless
they are true for every operation, while preserving the documented
supported-platform details.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 48af99d9-cf48-44c9-a8a4-ccd8f997b286
📒 Files selected for processing (1)
docs/index.md
Moves the README screenshots and the Time Slider animation off files.opengeos.org onto the project's own asset host, matching the landing page. Images live under /images, the GIF and WebM under /demos.
giswqs
changed the title
Covers the references the README pass missed: the demos gallery, the Whitebox screenshot, and the AppStream screenshot in both the metainfo and the script that renders it. Nothing in the repo points at the old host now, so the contributing note no longer lists it.
| <div class="hero__media"> | ||
| <figure> | ||
| <a href="https://share.geolibre.app/giswqs/3d-tiles" title="Open the 3D Tiles map"> | ||
| <img src="https://assets.geolibre.app/images/GeoLibre-demo.webp" alt="GeoLibre map interface showing the GIS workspace"> |
There was a problem hiding this comment.
This migrates GeoLibre-demo.webp/nyc-buildings.webp to assets.geolibre.app, matching the README change in this PR, but the identical images are also embedded in docs/demos.md and docs/user-guide/processing.md (whitebox.webp), which still point at files.opengeos.org and weren't touched here. That leaves the same pictures served from two different hosts across the docs site, and those other pages will break together if files.opengeos.org is ever retired. Might be worth a follow-up to finish the migration there.
Confidence: medium.
Code reviewBugs: None found. All URL replacements ( Security: None found. Doc-only change; no user input handling, no injected content, no secrets. Performance: None found. Not applicable to this change. Quality:
CLAUDE.md: No violations. The change stays within docs/README/packaging scope, keeps No inline comments posted — nothing met the bar for a specific, actionable finding. |
Summary
files.opengeos.orgonto the project's own asset host: images underassets.geolibre.app/images, the GIF and WebM underassets.geolibre.app/demos.Test plan
mkdocs serveand confirm both hero images load, are spaced evenly, and open their shared maps when clicked.Summary by CodeRabbit