-
-
Notifications
You must be signed in to change notification settings - Fork 672
docs: link hero screenshots and move media to assets.geolibre.app #1792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
0d7c500
docs(home): add a second hero screenshot
giswqs c90a4a6
docs(home): link the NYC hero screenshot to its shared map
giswqs 5fd5f8b
docs(home): link the workspace hero screenshot to its shared map
giswqs 592b7bf
docs(index): remove network analysis and geocoding section
giswqs 092faaa
style: auto-format (ruff + oxfmt) [pre-commit.ci]
pre-commit-ci[bot] f639c87
docs(readme): serve media from assets.geolibre.app
giswqs 89fe4be
docs: finish the move of media to assets.geolibre.app
giswqs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -85,6 +85,12 @@ | |
| } | ||
|
|
||
| .hero__media { | ||
| display: grid; | ||
| gap: 1rem; | ||
| margin: 0; | ||
| } | ||
|
|
||
| .hero__media figure { | ||
| margin: 0; | ||
| } | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very low confidence, quality/a11y nit: both hero images are now wrapped in
<a>links with atitleattribute describing the destination ("Open the 3D Tiles map" / "Open the New York City buildings and subways map"), but no visible/link text. Screen readers typically derive a link's accessible name from the child<img alt>(which describes the image content, e.g. "GeoLibre map interface showing the GIS workspace") rather than reliably announcingtitle. Consider anaria-labelon the<a>(or reusing thetitletext as the accessible name) if the destination context should be conveyed to AT users — optional, not blocking.