Skip to content

[DATABRICKS-2] PLU-600: add databricks app skeleton, auth, and client setup#1527

Open
pregnantboy wants to merge 1 commit intodatabricks/1-configfrom
databricks/2-app-skeleton
Open

[DATABRICKS-2] PLU-600: add databricks app skeleton, auth, and client setup#1527
pregnantboy wants to merge 1 commit intodatabricks/1-configfrom
databricks/2-app-skeleton

Conversation

@pregnantboy
Copy link
Copy Markdown
Contributor

@pregnantboy pregnantboy commented Apr 7, 2026

Add Databricks integration

Add Databricks app definition with icon, OAuth token management with Redis caching, DBSQLClient session creation, schema name construction, and register the app in the app registry.

Changes

  • Create Databricks app structure with favicon SVG icon and empty actions/dynamic-data exports
  • Implement OAuth token persistence with Redis caching and automatic token refresh
  • Add DBSQLClient session creation with proper logging and connection management
  • Create schema name construction utility that converts user email to valid schema format
  • Define TypeScript interfaces for Databricks column and table response objects
  • Register Databricks app in main app registry and GraphQL query rankings

Copy link
Copy Markdown
Contributor Author

pregnantboy commented Apr 7, 2026

@linear
Copy link
Copy Markdown

linear bot commented Apr 7, 2026

@pregnantboy pregnantboy marked this pull request as ready for review April 7, 2026 07:01
@pregnantboy pregnantboy requested a review from a team as a code owner April 7, 2026 07:01
Comment thread packages/backend/src/apps/databricks/auth/token-persistence.ts Outdated
@pregnantboy pregnantboy force-pushed the databricks/2-app-skeleton branch from 7651d1b to ed3204a Compare April 7, 2026 09:43
@pregnantboy pregnantboy force-pushed the databricks/1-config branch from ea2f638 to 0da7c5f Compare April 7, 2026 09:43
Comment thread packages/backend/src/apps/databricks/auth/create-client.ts
@pregnantboy pregnantboy force-pushed the databricks/2-app-skeleton branch from ed3204a to c7de60f Compare April 13, 2026 03:08
@pregnantboy pregnantboy force-pushed the databricks/1-config branch from 0da7c5f to d33c9d8 Compare April 13, 2026 03:08
Copy link
Copy Markdown
Contributor

@kevinkim-ogp kevinkim-ogp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

graphite's comment seems valid. other than that, lgtm!

@pregnantboy pregnantboy force-pushed the databricks/2-app-skeleton branch from c7de60f to f03d4f1 Compare April 16, 2026 08:44
@pregnantboy pregnantboy force-pushed the databricks/1-config branch from d33c9d8 to 8629e4e Compare April 16, 2026 08:44
@datadog-opengovsg

This comment has been minimized.

Add Databricks app definition with icon, OAuth token management with
Redis caching, DBSQLClient session creation, schema name construction,
and register the app in the app registry.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@pregnantboy pregnantboy force-pushed the databricks/2-app-skeleton branch from f03d4f1 to 6741ce2 Compare April 17, 2026 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants