[DATABRICKS-5] PLU-600: add frontend support for databricks dynamic actions#1530
Open
pregnantboy wants to merge 1 commit intodatabricks/4-create-rowfrom
Open
[DATABRICKS-5] PLU-600: add frontend support for databricks dynamic actions#1530pregnantboy wants to merge 1 commit intodatabricks/4-create-rowfrom
pregnantboy wants to merge 1 commit intodatabricks/4-create-rowfrom
Conversation
This was referenced Apr 7, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 7, 2026
pregnantboy
changed the title
pregnantboy
force-pushed
the
databricks/5-frontend
branch
from
8cac423 to
dae7518
Compare
pregnantboy
force-pushed
the
databricks/4-create-row
branch
2 times, most recently
from
189d3bc to
f94b3fa
Compare
pregnantboy
force-pushed
the
databricks/5-frontend
branch
2 times, most recently
from
382be49 to
735d13a
Compare
pregnantboy
force-pushed
the
databricks/4-create-row
branch
from
f94b3fa to
6ee411e
Compare
pregnantboy
force-pushed
the
databricks/5-frontend
branch
from
735d13a to
4440c19
Compare
pregnantboy
force-pushed
the
databricks/4-create-row
branch
from
6ee411e to
41da125
Compare
kevinkim-ogp
approved these changes
Apr 15, 2026
Contributor
kevinkim-ogp
left a comment
kevinkim-ogp
left a comment
There was a problem hiding this comment.
two small nits, other than that lgtm tested and works 🧱
pregnantboy
force-pushed
the
databricks/4-create-row
branch
from
41da125 to
a3de2ea
Compare
pregnantboy
force-pushed
the
databricks/5-frontend
branch
from
4440c19 to
14cd673
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+52
to
+54
| if (!/^[a-zA-Z0-9_]+$/.test(value)) { | ||
| return 'Only alphanumeric characters and underscores are allowed' | ||
| } |
There was a problem hiding this comment.
Validation regex doesn't match user-facing description. The regex /^[a-zA-Z0-9_]+$/ allows both uppercase AND lowercase letters, but line 81 tells users "Only lowercase letters, numbers and underscores allowed."
// Current regex allows uppercase:
if (!/^[a-zA-Z0-9_]+$/.test(value)) {
// Should be lowercase only:
if (!/^[a-z0-9_]+$/.test(value)) {Users will successfully create tables with uppercase letters, which may fail in Databricks if it requires lowercase names.
Spotted by Graphite
Is this helpful? React 👍 or 👎 to let us know.
Add dynamic action GraphQL mutation, refactor AddNewOptionModal to be config-driven with validation support, add databricks create-table and create-column cases, support inline validation on SingleSelect, and update collaborator restrictions to use addNewId-based checks. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
pregnantboy
force-pushed
the
databricks/4-create-row
branch
from
a3de2ea to
775b175
Compare
pregnantboy
force-pushed
the
databricks/5-frontend
branch
from
14cd673 to
4e8abbc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add dynamic action support and validation for dropdown options
Add dynamic action GraphQL mutation for creating Databricks tables and columns. Refactor AddNewOptionModal to use configuration-driven approach with validation support for different dropdown types. Implement inline validation for SingleSelect components and update collaborator permission checks to use addNewId-based restrictions instead of field-based ones.
DYNAMIC_ACTIONGraphQL mutation for handling dynamic dropdown actionsADD_NEW_OPTION_CONFIGSwith validation functionsdatabricks-createTableanddatabricks-createTableColumnin create new option flowCOLLABORATOR_RESTRICTED_ADDNEW_IDSinstead of field labels