[pirateweather] Initial contribution - #18877
Conversation
lolodomo
added
the
new binding
lsiepel
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
9b00ef4 to
82e63e2
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
@computergeek1507 are you able to proceed? Let me know if you need any assistence. |
f55d3bb to
df33a97
Compare
|
@lsiepel I tried to do implement your suggestions, please let me know if what else I need to do. |
Please fix the build and if you expand all comments, there are some that look unresolved / not commented on. If those are fixed, i expect to finish with a last review round. |
|
Please add yourself to the CODEOWNERS file. |
|
Please also add the binding here: https://github.com/openhab/openhab-addons/blob/main/bom/openhab-addons/pom.xml |
lsiepel
left a comment
lsiepel
left a comment
There was a problem hiding this comment.
This review covers the whole binding and i think these are my final comments.
|
@computergeek1507 we have about 4 weeks left for 5.1.0 would be cool to have this added. |
|
There is also a spotless build issue |
|
Gentle ping @computergeek1507 |
a210701 to
6f45a38
Compare
Signed-off-by: Scott Hanson <scooter_seh@yahoo.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Scott Hanson <scooter_seh@yahoo.com>
Signed-off-by: Scott Hanson <scooter_seh@yahoo.com>
…enhab/binding/pirateweather/internal/config/PirateWeatherChannelConfiguration.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Scott Hanson <computergeek1507@users.noreply.github.com>
…enhab/binding/pirateweather/internal/handler/PirateWeatherAPIHandler.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Scott Hanson <computergeek1507@users.noreply.github.com>
Signed-off-by: Scott Hanson <scooter_seh@yahoo.com>
Signed-off-by: Scott Hanson <scooter_seh@yahoo.com>
…H-INF/thing/bridge-types.xml Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Scott Hanson <computergeek1507@users.noreply.github.com>
…enhab/binding/pirateweather/internal/discovery/PirateWeatherDiscoveryService.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Scott Hanson <computergeek1507@users.noreply.github.com>
…enhab/binding/pirateweather/internal/discovery/PirateWeatherDiscoveryService.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Scott Hanson <computergeek1507@users.noreply.github.com>
Signed-off-by: Scott Hanson <scooter_seh@yahoo.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
lsiepel
left a comment
lsiepel
left a comment
There was a problem hiding this comment.
Thanks LGTM
Just did a rebase and added a commit to fix some build warnings. That is easier then when i add suggestions and you hit the add commit button and it is essentially the same.
I think this is now ready to merge. @computergeek1507 Please confirm all is as expected, we are close to the freeze periode before the next release.
I will only merge at the very last moment to give time to @openhab/add-ons-maintainers to look at the commit i created. The rest was reviewede by me already.
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
[Pirate Weather] Initial contribution
Description
I created a binding for Pirate Weather.
I used the 2.5 Dark Sky addon as a template and update the code to compile on openHAB 5.