[timescaledb] Upgrade libraries and make Docker test optional

[holgerfriedrich]

• Upgrade postgresql from 42.7.9 to 42.7.11
• Upgrade hikari from 5.1.0 to 7.0.2 (lifting req. to Java 11)
• Make Docker test optional to avoid failure if Docker is not available
• Small adaptions

[lsiepel]

Thanks LGTM

Awaiting upload to jfrog (@florian-h05)

[lsiepel]

I would also expect the feature.xml to be update similar to
https://github.com/openhab/openhab-addons/pull/20722/changes

[holgerfriedrich]

I would also expect the feature.xml to be update similar to https://github.com/openhab/openhab-addons/pull/20722/changes

I don't think so. It seems the design decision for timescaledb was to embed the driver into the binding jar.

	<feature name="openhab-persistence-timescaledb" description="TimescaleDB Persistence" version="${project.version}">
		<feature>openhab-runtime-base</feature>
		<bundle start-level="80">mvn:org.openhab.addons.bundles/org.openhab.persistence.timescaledb/${project.version}</bundle>
	</feature>

Looking at the pom, all runtime dependencies seem to be pulled in using scope compile.

Overall it seems we drift away from sharing libs (OSGI bundles) to embedding them per binding.
I have seen the same for okio - where we have both OSGI and embedded versions.

[lsiepel]

Yes, we could change it to provided and use the feature as the other persistence already shares it.

[holgerfriedrich]

Ok, I have to adapt my comment above:
jdbc persistence also pulls in the libs with default scope, i.e. compile. It just drops them during packaging to save space, leading to the situation that the jar files need to be put in place for the specific databases.
This is not what we want for a default service like timescaledb.

The OSGI packages mentioned above are a different topic. DB drivers are probably not OSGI packages.

[florian-h05]

I‘ve uploaded Hikari to JFrog, so you can OSGi-ify this dependency if you want.

[lsiepel]

Was not talking about hikari, not sure if that is used elsewhere. Was mainly talking about postgresql:

openhab-addons/bundles/org.openhab.persistence.jdbc/src/main/feature/feature.xml

Line 46 in da9a00c

<bundle start-level="80">mvn:org.postgresql/postgresql/42.7.11</bundle>

[lsiepel]

Suggested change

	<scope>provided</scope>

[lsiepel]

the suggestion seems to be at some wrong line... compiled => provided

[holgerfriedrich]

I am not sure if I like to do this change. Timescaledb is installed per default and I don't want to complicate things now.

[lsiepel]

Not sure what you mean by per default. It is just a add-on like any other. I'll create a seperate PR to make use of the osgi feature sharing

[lsiepel]

Thanks, LGTM

[holgerfriedrich]

@lsiepel I had somehow in mind that timescale is installed by the setup wizard. That's not the case.... Sorry for the confusion.