Enable HTTP/2 for HTTPS - #1711
Conversation
Signed-off-by: Florian Hotze <dev@florianhotze.com>
|
Isn't that removing http/1.1 support for secure connections? |
|
Yes, but I see no harm in doing so: |
|
I'm ok with that, but I would like to hear the opinion of other @openhab/distro-maintainers and @openhab/architecture-council |
|
Let's also ask @ghys for his opinion. |
|
I had to keep http/1 and TLS 1.1 for quite a while longer than I wanted due to Android-based wall displays. But it is more than ten years since Android 4 and time to get rid of those devices anyway - if still in use. So 👍 from my side. |
|
If really needed, you could use nginx to get http/1 and TLS 1.1 available for them - but given the vulnerabilities of TLS 1.1 you could also consider to use plain HTTP ;-) |
Signed-off-by: Florian Hotze <dev@florianhotze.com>
J-N-K
left a comment
J-N-K
left a comment
There was a problem hiding this comment.
Thanks. Let's wait for more comments.
|
I think there will be much complaining but I also think this is somethjing that probably needs to be done anyway. Never underestimate the willingness of people to keep running stuff far beyond it's end of life. I would request an update to the reverse proxy docs to correspond with this change, assuming end users need to adjust their nginx or apache configs to account for this. |
If one has a browser older than 2015 (where HTTP/2 was added to all major browsers) I wish them good luck to not get some malware while surfing … |
|
I guess 10 years after the general availability of a successor, it should be ok to drop HTTP/1.1+TLS1.1 - so no veto from me. |
holgerfriedrich
left a comment
holgerfriedrich
left a comment
There was a problem hiding this comment.
LGTM.
I managed to connect with HTTP2 and HTTP w. keepalive.
Let's see how it works out for the bigger audience.
See openhab#1711 (comment). This change is not needed, the demo app starts fine without it. Signed-off-by: Florian Hotze <dev@florianhotze.com>
Sorry I was AFK for the holidays but it's a good move IMO. |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/wget-and-sendhttpgetrequest-empty-response-differend/161321/6 |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/oh5-apache-reverse-proxy-issues/162338/5 |
Regression from openhab#1711. Fixes openhab/openhab-webui#3125. Signed-off-by: Florian Hotze <dev@florianhotze.com>
* Add JavaDoc links * Fix WebSocket over HTTPS not working Regression from #1711. Fixes openhab/openhab-webui#3125. Signed-off-by: Florian Hotze <dev@florianhotze.com>
7 participants
Depends on openhab/openhab-core#4526.