feat: widen support to Angular 20-22 - #17
Merged
Merged
Conversation
JasonWeinzierl
force-pushed
the
peer-22
branch
from
August 23, 2026 17:34
f2b6a3a to
c3a5021
Compare
4 tasks
There was a problem hiding this comment.
Pull request overview
Expands Angular support to versions 20–22, updates the project baseline to Angular 20, and migrates tests to Vitest.
Changes:
- Widens Angular peer dependencies and adds compatibility CI.
- Updates dependencies, documentation, and Node version configuration.
- Replaces Karma/Jasmine testing with Vitest.
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Summary |
|---|---|
tsconfig.spec.json |
Configures Vitest globals. |
src/app/toasts.spec.ts |
Migrates tests to Vitest APIs. |
scripts/test-peer-compatibility.mjs |
Adds Angular-version compatibility testing. |
README.md |
Documents Angular 20–22 support. |
projects/ngx-toastr/package.json |
Widens Angular peer dependencies. |
package.json |
Updates Angular and test tooling dependencies. |
karma.conf.js |
Removes obsolete Karma configuration. |
angular.json |
Configures the Vitest test target; critical issue: invalid Karma-style coverage option names will prevent ng test from running. |
.nvmrc |
Replaced by .node-version. |
.node-version |
Defines the Node.js version. |
.github/workflows/publish.yml |
Uses .node-version. |
.github/workflows/pr-title.yml |
Uses .node-version. |
.github/workflows/ci.yml |
Adds Angular compatibility testing. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
JasonWeinzierl
force-pushed
the
peer-22
branch
from
August 24, 2026 20:56
c3a5021 to
39a7c57
Compare
JasonWeinzierl
marked this pull request as ready for review
August 24, 2026 20:56
JasonWeinzierl
force-pushed
the
peer-22
branch
from
August 24, 2026 20:56
39a7c57 to
8d58431
Compare
- Downgrade the repo version to Angular 20 because Angular documentation states you should build with the oldest supported version. - Install zone.js because Angular 20 needs it. - Expand peer range to all Angular versions still under active declared support. - Add CI script to validate peer compatibility. - Add `platform-browser` to peer deps to avoid hidden dependency and support pnpm
JasonWeinzierl
force-pushed
the
peer-22
branch
5 times, most recently
from
August 24, 2026 21:13
68770f8 to
5b3943a
Compare
12 tasks
JasonWeinzierl
force-pushed
the
peer-22
branch
from
August 24, 2026 21:26
2b00804 to
00f2e88
Compare
|
Any chance we can get this merged? This is the last dependency blocking my update to Angular 22. |
geromegrignon
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ng newto bootstrap fresh projects. Seemed to be more than we need, and probably slower. (2) in-place modifying the package.json dependencies to 20, 21, and 22. Less isolated than the temporary directory approach and risks mutating the library so the test isn't accurate..nvmrcwith.node-version, thanks for the recommendation in Feature/angular v22 support #7 .platform-browserto the peer dependencies to fixpnpmsupport and avoid a hidden dependency.Related issues
Fixes #6
Type of change
Breaking changes
None
This should not be a breaking change since we're maintaining support for Angular 21.
Test plan
npm run buildnpm testnpm run lintChecklist
Additional context