Skip to content

Feature/angular v22 support - #7

Closed
JeevanMahesha wants to merge 2 commits into
openng-org:mainfrom
JeevanMahesha:feature/angular-v22-support
Closed

Feature/angular v22 support#7
JeevanMahesha wants to merge 2 commits into
openng-org:mainfrom
JeevanMahesha:feature/angular-v22-support

Conversation

@JeevanMahesha

Copy link
Copy Markdown
Contributor

Description

Upgrades the demo app and tooling from Angular v21 to v22: bumps @angular/*, @angular/cli, ng-packagr, eslint/typescript-eslint, jasmine-core, typescript, and related dev dependencies. Also cleans up code flagged by the new tooling — removes the now-default OnPush change detection strategy, drops unused module imports from AppComponent, and converts the demo pink-toast component's undoString field to a signal.

Related issues

Relates to #6

Type of change

  • Refactor, test, or chore (no user-facing change)

Breaking changes

None

Test plan

  • npm run build
  • npm test
  • npm run lint
  • Verified in the demo app (if applicable)

Checklist

  • Issue discussed or bug clearly described (link issue when applicable)
  • Tests added or updated for behavioral changes
  • Documentation updated (README, JSDoc, migration notes as needed)
  • Public API changes documented; breaking changes called out
  • CHANGELOG updated (if the repository maintains one and the change is user-facing)
  • Commit messages follow Conventional Commits
  • I agree to follow the OpenNG Foundation Code of Conduct

Additional context

This covers the demo app + build tooling only. The library's own peerDependencies (projects/ngx-toastr/package.json) are still ^21.0.0 and need a follow-up bump to ^22.0.0 before #6 can be closed.

@JasonWeinzierl

JasonWeinzierl commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Thank you! The current goal for a v1 release of this library is no changes beyond what's necessary to publish to npm, so we keep backward compatibility with the old library. But feel free to keep this up for v2!

@omansak

omansak commented Aug 18, 2026

Copy link
Copy Markdown

@JasonWeinzierl, could you release v2 as soon as possible?
This PR looks good.
Maybe we can just remove lodash-es from the app.

@JasonWeinzierl

Copy link
Copy Markdown
Collaborator

We're working on getting the backward-compatible version off the ground to make migrating as easy as possible. You can follow progress in #8

@JeevanMahesha
JeevanMahesha force-pushed the feature/angular-v22-support branch from c8ea8f6 to 639a13e Compare August 24, 2026 14:46
Bumps Angular packages, CLI, ng-packagr, eslint/typescript-eslint, and other dev deps from v21 to v22; drops redundant OnPush change detection default, removes unused module imports in AppComponent, and converts the demo pink-toast component's undoString to a signal.
@JeevanMahesha
JeevanMahesha force-pushed the feature/angular-v22-support branch from 639a13e to b9a26a9 Compare August 24, 2026 14:50
@JasonWeinzierl

Copy link
Copy Markdown
Collaborator

Closing in favor of #17, thanks!

JasonWeinzierl added a commit that referenced this pull request Aug 24, 2026
JasonWeinzierl added a commit that referenced this pull request Aug 24, 2026
JasonWeinzierl added a commit that referenced this pull request Aug 24, 2026
JasonWeinzierl added a commit that referenced this pull request Aug 27, 2026
* feat: support Angular 20-22

- Downgrade the repo version to Angular 20 because Angular documentation states you should build with the oldest supported version.
- Install zone.js because Angular 20 needs it.
- Expand peer range to all Angular versions still under active declared support.
- Add CI script to validate peer compatibility.
- Add `platform-browser` to peer deps to avoid hidden dependency and support pnpm

* chore: add .node-version file and remove .nvmrc

Thanks #7

* docs: document new supported range

* refactor: simplifications thanks to #7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants