feat!: @openng rename - #3
Merged
Merged
Conversation
BREAKING CHANGE: the package is now named `@openng/ngx-toastr`. The demo app has been updated to use it.
geromegrignon
self-requested a review
July 28, 2026 13:12
geromegrignon
requested changes
Jul 28, 2026
There was a problem hiding this comment.
Pull request overview
This PR implements the breaking rename of the library package to the @openng namespace, updating the workspace/demo imports and documentation accordingly, and refreshing repo/site metadata (including Open Graph tags) to reflect the new ownership.
Changes:
- Renames the published package to
@openng/ngx-toastrand updates TypeScript path mapping and all internal/demo imports. - Updates documentation (README) to the new package scope and removes legacy SystemJS guidance.
- Updates site metadata/links (index.html, header/footer) and adds OpenNG attribution to the MIT LICENSE.
Reviewed changes
Copilot reviewed 18 out of 20 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.json | Updates TS path alias to resolve @openng/ngx-toastr locally. |
| src/main.ts | Switches demo bootstrap import to @openng/ngx-toastr. |
| src/index.html | Updates title/author/URLs and fixes Open Graph tags to use property. |
| src/app/toasts.spec.ts | Updates test imports to @openng/ngx-toastr. |
| src/app/toast-manager.service.ts | Updates service imports to @openng/ngx-toastr. |
| src/app/pink-toast/pink-toast.component.ts | Updates toast component import path. |
| src/app/notyf-toast/notyf-toast.component.ts | Updates toast component import path. |
| src/app/home/home.component.ts | Updates demo home imports to new package scope. |
| src/app/header/header.component.ts | Updates displayed title and GitHub button org/user. |
| src/app/footer/footer.component.ts | Updates repository/license links to new org. |
| src/app/bootstrap-toast/bootstrap-toast.component.ts | Updates toast component import path. |
| src/app/app.component.ts | Updates module import to new package scope. |
| README.md | Updates install/setup/docs to @openng/ngx-toastr and removes SystemJS section. |
| projects/ngx-toastr/src/public-api.ts | Updates public API header comment to new package name. |
| projects/ngx-toastr/src/lib/toastr/toast.provider.ts | Updates JSDoc example import to new package scope. |
| projects/ngx-toastr/package.json | Renames published package name and updates repository URL. |
| package.json | Updates repository URL at the workspace root. |
| package-lock.json | Adds missing root license field. |
| LICENSE | Adds OpenNG contributors attribution. |
| .vscode/settings.json | Adjusts VS Code settings (but currently introduces invalid JSON). |
馃挕 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thanks @JasonWeinzierl There are some aspects i need to address in private with you for write access, I sent you a LinkedIn connection. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The package has been renamed to with the
@openngnamespace. Documentation has been updated. References to SystemJS have been removed. OpenNG has been added to LICENSE. Open Graph metadata has been fixed (needs to useproperty).Related issues
Type of change
Breaking changes
Import path is now
@openng/ngx-toastrinstead ofngx-toastr.Test plan
npm run buildnpm testnpm run lintChecklist
Additional context
This is not everything for release. Out of scope for this PR: