Skip to content

Fix phonetics for 比 - #732

Merged
lukhnos merged 3 commits into
openvanilla:masterfrom
xatier:bi
Nov 14, 2025
Merged

Fix phonetics for 比#732
lukhnos merged 3 commits into
openvanilla:masterfrom
xatier:bi

Conversation

@xatier

@xatier xatier commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

The concise dictionary prefers 排比 ㄆㄞˊ ㄅㄧˋ

Ref: https://dict.concised.moe.edu.tw/search.jsp?md=1&word=%E6%AF%94&size=-1

The concise dictionary prefers `排比 ㄆㄞˊ ㄅㄧˋ`

Ref: https://dict.concised.moe.edu.tw/search.jsp?md=1&word=%E6%AF%94&size=-1
Copilot AI review requested due to automatic review settings November 5, 2025 01:51
@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @xatier, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a data accuracy issue by correcting the phonetic transcription for the Chinese character "比". The change involves adding the correct Bopomofo and Pinyin entry to the BPMFBase.txt file, ensuring that the phonetic data is consistent with authoritative dictionary references.

Highlights

  • Phonetic Correction: The phonetic entry for the Chinese character "比" has been added to the BPMFBase.txt file.
  • Data Accuracy: The change aligns the phonetic data with the concise dictionary's preferred transcription, specifically ㄆㄧˊ pi2.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

此拉取請求為「比」字增加了「ㄆㄧˊ」的讀音。此變更本身沒有問題,但我已在程式碼註解中指出,拉取請求的描述與變更內容不符,建議修正以增加清晰度。

Comment thread Source/Data/BPMFBase.txt
藣 ㄆㄧˊ pi2 qu6 big5
蠯 ㄆㄧˊ pi2 qu6 big5
蚍 ㄆㄧˊ pi2 qu6 big5
比 ㄆㄧˊ pi2 qu6 big5

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

這個 PR 為「比」字增加了「ㄆㄧˊ」的讀音。然而,PR 的描述中提到的是「排比」的「ㄅㄧˋ」讀音,這會造成困惑。建議更新 PR 描述,解釋為何要增加「ㄆㄧˊ」這個讀音,如果可能的話,也請提供使用範例(例如:詞語),以利於審核。謝謝。

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you see this? 皋比 ㄍㄠ ㄆㄧˊ

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds new Chinese phrases and character readings to the McBopomofo dictionary data, including multi-character phrases and a heterophony reading for the character "比".

  • Adds 4 new multi-character phrases with their Bopomofo mappings and frequencies
  • Adds a heterophony reading "比 ㄆㄧˊ" to BPMFBase.txt
  • Adds an alternative reading "排比 ㄆㄞˊ ㄅㄧˋ" to BPMFMappings.txt

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
Source/Data/phrase.occ Adds frequency entries for 4 new phrases: 奇大無比, 完全比賽, 皋比, and 類比電腦 with frequency 0
Source/Data/BPMFMappings.txt Adds Bopomofo mappings for the 4 new phrases and an alternative reading for 排比
Source/Data/BPMFBase.txt Adds heterophony reading ㄆㄧˊ for the character 比

Comment thread Source/Data/BPMFBase.txt
藣 ㄆㄧˊ pi2 qu6 big5
蠯 ㄆㄧˊ pi2 qu6 big5
蚍 ㄆㄧˊ pi2 qu6 big5
比 ㄆㄧˊ pi2 qu6 big5

Copilot AI Nov 5, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The character '比' is a heterophony character. It already has readings ㄅㄧˇ (line 549) and ㄅㄧˋ (line 594) in BPMFBase.txt, and ㄅㄧˇ is listed in heterophony1.list (line 261) as the default reading. Since you are adding a new reading ㄆㄧˊ, you should: 1) Add a comment in BPMFBase.txt indicating this is a heterophony character and noting the relative frequency of each reading, and 2) Add '比 ㄆㄧˊ' to heterophony2.list or heterophony3.list depending on the frequency of this reading compared to the existing ones.

Copilot generated this review using guidance from repository custom instructions.
排架 ㄆㄞˊ ㄐㄧㄚˋ
排檔 ㄆㄞˊ ㄉㄤˇ
排比 ㄆㄞˊ ㄅㄧˇ
排比 ㄆㄞˊ ㄅㄧˋ

Copilot AI Nov 5, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phrase '排比' now has two readings: ㄆㄞˊ ㄅㄧˇ (line 61189) and ㄆㄞˊ ㄅㄧˋ (line 61190). Since the character '比' has different readings, and you are adding an alternative reading for the phrase, consider whether this less common reading should have a corresponding entry in phrase.occ if it represents a different meaning or usage context. Currently, phrase.occ only has one entry for '排比' with frequency 5.

Copilot generated this review using guidance from repository custom instructions.
@zonble

zonble commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

這個應該要一起更新破音字表格?

Comment thread Source/Data/heterophony2.list Outdated

@lukhnos lukhnos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lukhnos
lukhnos merged commit 489c893 into openvanilla:master Nov 14, 2025
5 checks passed
@xatier
xatier deleted the bi branch April 3, 2026 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants