Fix phonetics for 比 - #732
Conversation
The concise dictionary prefers `排比 ㄆㄞˊ ㄅㄧˋ` Ref: https://dict.concised.moe.edu.tw/search.jsp?md=1&word=%E6%AF%94&size=-1
Summary of ChangesHello @xatier, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a data accuracy issue by correcting the phonetic transcription for the Chinese character "比". The change involves adding the correct Bopomofo and Pinyin entry to the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
| 藣 ㄆㄧˊ pi2 qu6 big5 | ||
| 蠯 ㄆㄧˊ pi2 qu6 big5 | ||
| 蚍 ㄆㄧˊ pi2 qu6 big5 | ||
| 比 ㄆㄧˊ pi2 qu6 big5 |
There was a problem hiding this comment.
Did you see this? 皋比 ㄍㄠ ㄆㄧˊ
There was a problem hiding this comment.
Pull Request Overview
This PR adds new Chinese phrases and character readings to the McBopomofo dictionary data, including multi-character phrases and a heterophony reading for the character "比".
- Adds 4 new multi-character phrases with their Bopomofo mappings and frequencies
- Adds a heterophony reading "比 ㄆㄧˊ" to BPMFBase.txt
- Adds an alternative reading "排比 ㄆㄞˊ ㄅㄧˋ" to BPMFMappings.txt
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Source/Data/phrase.occ | Adds frequency entries for 4 new phrases: 奇大無比, 完全比賽, 皋比, and 類比電腦 with frequency 0 |
| Source/Data/BPMFMappings.txt | Adds Bopomofo mappings for the 4 new phrases and an alternative reading for 排比 |
| Source/Data/BPMFBase.txt | Adds heterophony reading ㄆㄧˊ for the character 比 |
| 藣 ㄆㄧˊ pi2 qu6 big5 | ||
| 蠯 ㄆㄧˊ pi2 qu6 big5 | ||
| 蚍 ㄆㄧˊ pi2 qu6 big5 | ||
| 比 ㄆㄧˊ pi2 qu6 big5 |
There was a problem hiding this comment.
The character '比' is a heterophony character. It already has readings ㄅㄧˇ (line 549) and ㄅㄧˋ (line 594) in BPMFBase.txt, and ㄅㄧˇ is listed in heterophony1.list (line 261) as the default reading. Since you are adding a new reading ㄆㄧˊ, you should: 1) Add a comment in BPMFBase.txt indicating this is a heterophony character and noting the relative frequency of each reading, and 2) Add '比 ㄆㄧˊ' to heterophony2.list or heterophony3.list depending on the frequency of this reading compared to the existing ones.
| 排架 ㄆㄞˊ ㄐㄧㄚˋ | ||
| 排檔 ㄆㄞˊ ㄉㄤˇ | ||
| 排比 ㄆㄞˊ ㄅㄧˇ | ||
| 排比 ㄆㄞˊ ㄅㄧˋ |
There was a problem hiding this comment.
The phrase '排比' now has two readings: ㄆㄞˊ ㄅㄧˇ (line 61189) and ㄆㄞˊ ㄅㄧˋ (line 61190). Since the character '比' has different readings, and you are adding an alternative reading for the phrase, consider whether this less common reading should have a corresponding entry in phrase.occ if it represents a different meaning or usage context. Currently, phrase.occ only has one entry for '排比' with frequency 5.
|
這個應該要一起更新破音字表格? |
This reverts commit b985058.
The concise dictionary prefers
排比 ㄆㄞˊ ㄅㄧˋRef: https://dict.concised.moe.edu.tw/search.jsp?md=1&word=%E6%AF%94&size=-1