Skip to content

Fix phonetics for 比 #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukhnos merged 3 commits into from
Nov 14, 2025
Merged

Fix phonetics for 比 #732

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
54e9c6a
Fix phonetics for 比
xatier Nov 5, 2025
b985058
add 比 to heterophony2
xatier Nov 5, 2025
c98871f
Revert "add 比 to heterophony2"
xatier Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Source/Data/BPMFBase.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8065,6 +8065,7 @@
藣 ㄆㄧˊ pi2 qu6 big5
蠯 ㄆㄧˊ pi2 qu6 big5
蚍 ㄆㄧˊ pi2 qu6 big5
比 ㄆㄧˊ pi2 qu6 big5

@gemini-code-assist gemini-code-assist Bot Nov 5, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

這個 PR 為「比」字增加了「ㄆㄧˊ」的讀音。然而，PR 的描述中提到的是「排比」的「ㄅㄧˋ」讀音，這會造成困惑。建議更新 PR 描述，解釋為何要增加「ㄆㄧˊ」這個讀音，如果可能的話，也請提供使用範例（例如：詞語），以利於審核。謝謝。

@xatier xatier Nov 5, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you see this? 皋比 ㄍㄠ ㄆㄧˊ

Copilot AI Nov 5, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The character '比' is a heterophony character. It already has readings ㄅㄧˇ (line 549) and ㄅㄧˋ (line 594) in BPMFBase.txt, and ㄅㄧˇ is listed in heterophony1.list (line 261) as the default reading. Since you are adding a new reading ㄆㄧˊ, you should: 1) Add a comment in BPMFBase.txt indicating this is a heterophony character and noting the relative frequency of each reading, and 2) Add '比 ㄆㄧˊ' to heterophony2.list or heterophony3.list depending on the frequency of this reading compared to the existing ones.

Copilot generated this review using guidance from repository custom instructions.
飄 ㄆㄧㄠ piao qul big5
漂 ㄆㄧㄠ piao qul big5
慓 ㄆㄧㄠ piao qul big5
Expand Down
5 changes: 5 additions & 0 deletions Source/Data/BPMFMappings.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39357,6 +39357,7 @@
奇境 ㄑㄧˊ ㄐㄧㄥˋ
奇士勞斯基 ㄑㄧˊ ㄕˋ ㄌㄠˊ ㄙ ㄐㄧ
奇士美 ㄑㄧˊ ㄕˋ ㄇㄟˇ
奇大無比 ㄑㄧˊ ㄉㄚˋ ㄨˊ ㄅㄧˇ
奇奇 ㄑㄧˊ ㄑㄧˊ
奇奇怪怪 ㄑㄧˊ ㄑㄧˊ ㄍㄨㄞˋ ㄍㄨㄞˋ
奇妙 ㄑㄧˊ ㄇㄧㄠˋ
Expand Down Expand Up @@ -42481,6 +42482,7 @@
完全中學 ㄨㄢˊ ㄑㄩㄢˊ ㄓㄨㄥ ㄒㄩㄝˊ
完全是 ㄨㄢˊ ㄑㄩㄢˊ ㄕˋ
完全會 ㄨㄢˊ ㄑㄩㄢˊ ㄏㄨㄟˋ
完全比賽 ㄨㄢˊ ㄑㄩㄢˊ ㄅㄧˇ ㄙㄞˋ
完全能 ㄨㄢˊ ㄑㄩㄢˊ ㄋㄥˊ
完全葉 ㄨㄢˊ ㄑㄩㄢˊ ㄧㄝˋ
完全變態 ㄨㄢˊ ㄑㄩㄢˊ ㄅㄧㄢˋ ㄊㄞˋ
Expand Down Expand Up @@ -61185,6 +61187,7 @@
排架 ㄆㄞˊ ㄐㄧㄚˋ
排檔 ㄆㄞˊ ㄉㄤˇ
排比 ㄆㄞˊ ㄅㄧˇ
排比 ㄆㄞˊ ㄅㄧˋ

Copilot AI Nov 5, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phrase '排比' now has two readings: ㄆㄞˊ ㄅㄧˇ (line 61189) and ㄆㄞˊ ㄅㄧˋ (line 61190). Since the character '比' has different readings, and you are adding an alternative reading for the phrase, consider whether this less common reading should have a corresponding entry in phrase.occ if it represents a different meaning or usage context. Currently, phrase.occ only has one entry for '排比' with frequency 5.

Copilot generated this review using guidance from repository custom instructions.
排氣 ㄆㄞˊ ㄑㄧˋ
排氣管 ㄆㄞˊ ㄑㄧˋ ㄍㄨㄢˇ
排氣量 ㄆㄞˊ ㄑㄧˋ ㄌㄧㄤˋ
Expand Down Expand Up @@ -94082,6 +94085,7 @@
皇額娘 ㄏㄨㄤˊ ㄜˊ ㄋㄧㄤˊ
皈依 ㄍㄨㄟ ㄧ
皈依於 ㄍㄨㄟ ㄧ ㄩˊ
皋比 ㄍㄠ ㄆㄧˊ
皎如日星 ㄐㄧㄠˇ ㄖㄨˊ ㄖˋ ㄒㄧㄥ
皎月 ㄐㄧㄠˇ ㄩㄝˋ
皎潔 ㄐㄧㄠˇ ㄐㄧㄝˊ
Expand Down Expand Up @@ -139040,6 +139044,7 @@
類此 ㄌㄟˋ ㄘˇ
類毒素 ㄌㄟˋ ㄉㄨˊ ㄙㄨˋ
類比 ㄌㄟˋ ㄅㄧˇ
類比電腦 ㄌㄟˋ ㄅㄧˇ ㄉㄧㄢˋ ㄋㄠˇ
類神經 ㄌㄟˋ ㄕㄣˊ ㄐㄧㄥ
類神經網路 ㄌㄟˋ ㄕㄣˊ ㄐㄧㄥ ㄨㄤˇ ㄌㄨˋ
類經 ㄌㄟˋ ㄐㄧㄥ
Expand Down
1 change: 1 addition & 0 deletions Source/Data/heterophony2.list
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
數 ㄕㄨˇ
朴 ㄆㄛˋ
欸 ㄞ
比 ㄅㄧˋ
Comment thread
xatier marked this conversation as resolved.
Outdated
波 ㄅㄛ
潰 ㄏㄨㄟˋ
為 ㄨㄟˋ
Expand Down
4 changes: 4 additions & 0 deletions Source/Data/phrase.occ
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38361,6 +38361,7 @@
奇境 4
奇士勞斯基 10
奇士美 2
奇大無比 0
奇奇 30
奇奇怪怪 5
奇妙 128
Expand Down Expand Up @@ -41728,6 +41729,7 @@
完全中學 11
完全是 133
完全會 4
完全比賽 0
完全能 5
完全葉 0
完全變態 2
Expand Down Expand Up @@ -96486,6 +96488,7 @@
皉 0
皊 0
皋 16
皋比 0
皎 50
皎如日星 0
皎月 0
Expand Down Expand Up @@ -145836,6 +145839,7 @@
類此 6
類毒素 0
類比 73
類比電腦 0
類神經 4
類神經網路 1
類經 8
Expand Down