Open
Conversation
| 1, 0, 0, 0, | ||
| 0, 1, 0, 0, | ||
| 0, 0, 1, -cameraHeight / sin(pitch), | ||
| 0, 0, 0, 1); |
Comment on lines
+1
to
+3
| #pragma once | ||
| #ifndef CONTOURDRAWER_H | ||
| #define CONTOURDRAWER_H |
There was a problem hiding this comment.
Зачем и pragma once, и стражи включения в старом стиле?
| class ContourDrawer | ||
| { | ||
| public: | ||
| static void colorContours(cv::Mat frame, const std::vector<std::vector<cv::Point>>& contours); |
There was a problem hiding this comment.
frame вроде тоже можно по константной ссылке передавать
| return resultImage; | ||
| } | ||
|
|
||
| cv::Mat ImageFilter::selectMinimumForEachPixel(std::deque<cv::Mat> images) |
There was a problem hiding this comment.
Вообще, у Вас параметры то по константной ссылке передаются, то по значению, как-то без системы. По значению плохо, потому что будет копирование при вызове.
| 0, 0, 1); | ||
|
|
||
| cv::Mat matrix = instrinsicMatrix * transformationMatrix; | ||
| //for (int i = 0; i < 3; i++) { |
There was a problem hiding this comment.
Ой, закомментированный код в основную ветку нельзя принимать
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.