fix: detect committer name/email as untrusted input in Dangerous Workflow check#4968
Open
alexchenai wants to merge 1 commit intoossf:mainfrom
Open
fix: detect committer name/email as untrusted input in Dangerous Workflow check#4968alexchenai wants to merge 1 commit intoossf:mainfrom
alexchenai wants to merge 1 commit intoossf:mainfrom
Conversation
…flow check The containsUntrustedContextPattern function detects author name/email for head_commit and commits[*], but misses the equivalent committer fields. Since git committer identity is independently controllable by attackers, these variables are equally dangerous in shell script injection contexts. Adds detection for: - github.event.head_commit.committer.name - github.event.head_commit.committer.email - github.event.commits[*].committer.name - github.event.commits[*].committer.email Fixes ossf#3915 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
alexchenai
requested review from
justaugustus and
raghavkaul
and removed request for
a team
dosubot
bot
added
the
size:S
2 tasks
|
This pull request has been marked stale because it has been open for 10 days with no activity |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
committer.nameandcommitter.emailpatterns to thecontainsUntrustedContextPatternfunction for bothhead_commitandcommits[*]contextsauthor.name/author.emailbut misses the equivalentcommitterfields, which are independently controllable by attackers and equally dangerous for script injectionFixes #3915 (partially -- addresses the committer gap identified by @pnacht in the issue comments)
Context
As noted by @pnacht in #3915 (comment), git committer identity is a separate field from author identity. An attacker can set arbitrary committer name/email values (e.g., via
GIT_COMMITTER_NAME/GIT_COMMITTER_EMAIL), making these variables unsafe to use in inline shell scripts without sanitization.Test plan
head_commit.committer.name,head_commit.committer.email,commits[*].committer.name,commits[*].committer.email🤖 Generated with Claude Code