fix: cleanup plaintext on gcmsiv/aessiv tag mismatch#70
Merged
paulmillr merged 3 commits intopaulmillr:mainfrom Apr 16, 2026
Merged
fix: cleanup plaintext on gcmsiv/aessiv tag mismatch#70paulmillr merged 3 commits intopaulmillr:mainfrom
paulmillr merged 3 commits intopaulmillr:mainfrom
Conversation
GCM-SIV decrypt did not zero the tentative plaintext buffer on tag verification failure, leaving unauthenticated data observable through heap inspection. AES-SIV decrypt had the same issue with its decrypted plaintext `p`. Both now call clean() on the plaintext before throwing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-Authored-By: DeepView Autofix <276251120+deepview-autofix@users.noreply.github.com> Co-Authored-By: Nikita Skovoroda <chalkerx@gmail.com> Signed-off-by: Nikita Skovoroda <chalkerx@gmail.com>
ChALkeR
reviewed
Apr 15, 2026
Co-authored-by: Nikita Skovoroda <chalkerx@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCM-SIV decrypt did not zero the tentative plaintext buffer on tag verification failure, leaving unauthenticated data observable through heap inspection. AES-SIV decrypt had the same issue with its decrypted plaintext
p. Both now call clean() on the plaintext before throwing.