Skip to content

fix: cleanup plaintext on gcmsiv/aessiv tag mismatch #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulmillr merged 3 commits into from
Apr 16, 2026
+2 −1
Merged

fix: cleanup plaintext on gcmsiv/aessiv tag mismatch #70

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f280ea1
fix: cleanup plaintext on gcmsiv/aessiv tag mismatch
deepview-autofix Apr 15, 2026
4f8c51c
fixup: do not add useless test
deepview-autofix Apr 15, 2026
25429e5
fixup: do not add useless test
deepview-autofix Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/aes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1138,7 +1138,7 @@ export const gcmsiv: TRet<
// RFC 8452 §5: plaintext is unauthenticated here and MUST NOT be
// returned until the expected-tag check completes successfully.
if (!equalBytes(tag, expectedTag)) {
clean(...toClean);
clean(plaintext, ...toClean);
throw new Error('invalid polyval tag');
}
// Cleanup
Expand Down Expand Up @@ -1971,6 +1971,7 @@ export const aessiv: TRet<
if (equalBytes(t, v)) {
return p as TRet<Uint8Array>;
} else {
clean(p);
throw new Error('invalid siv tag');
}
},
Expand Down
Loading