Skip to content

Use the correct Permit API Instead of CloudPDP API - #70

Merged
EliMoshkovich merged 7 commits into
masterfrom
PER-13618-fix-routing-pdp-url
Dec 18, 2025
Merged

Use the correct Permit API Instead of CloudPDP API#70
EliMoshkovich merged 7 commits into
masterfrom
PER-13618-fix-routing-pdp-url

Conversation

@EliMoshkovich

Copy link
Copy Markdown
Contributor

No description provided.

@linear

linear Bot commented Dec 18, 2025

Copy link
Copy Markdown

@zeevmoney
zeevmoney requested a review from Copilot December 18, 2025 20:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes routing issues by consolidating API client configuration. Previously, separate client configurations were created for different API endpoints (one for facts and one for regular APIs), which caused incorrect routing from cloudpdp to the API. The change unifies all API clients to use the same base client configuration.

  • Removed the separate facts client configuration
  • Updated all API endpoints to use the unified base client

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@zeevmoney zeevmoney changed the title Fix routing from cloudpdp to api Use the correct Permit API Instead of CloudPDP API Dec 18, 2025
@zeevmoney
zeevmoney requested a review from Copilot December 18, 2025 21:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pkg/api/api.go Outdated
zeevmoney and others added 3 commits December 18, 2025 23:01
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@zeevmoney
zeevmoney requested a review from Copilot December 18, 2025 21:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pkg/tests/integration_test.go
@EliMoshkovich
EliMoshkovich merged commit 7850065 into master Dec 18, 2025
3 of 4 checks passed
@EliMoshkovich
EliMoshkovich deleted the PER-13618-fix-routing-pdp-url branch December 18, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants