Skip to content
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions pkg/api/api.go
Original file line number Diff line number Diff line change
Expand Up @@ -175,9 +175,18 @@ func NewFactsClientConfig(config *config.PermitConfig) *openapi.Configuration {

func NewPermitApiClient(config *config.PermitConfig) *PermitApiClient {
baseClientConfig := NewClientConfig(config)
factsClientConfig := NewFactsClientConfig(config)
client := openapi.NewAPIClient(baseClientConfig)
factsClient := openapi.NewAPIClient(factsClientConfig)

// Deprecated: factsClient was previously always using PDP URL for facts APIs,
// which caused issues when proxyFactsViaPDP was false (the default).
// Now factsClient defaults to the regular client (API URL) and only uses
// PDP URL when proxyFactsViaPDP is explicitly enabled.
Comment thread
zeevmoney marked this conversation as resolved.
Outdated
factsClient := client
if config.GetProxyFactsViaPDP() {
factsClientConfig := NewFactsClientConfig(config)
factsClient = openapi.NewAPIClient(factsClientConfig)
}

return &PermitApiClient{
config: config,
logger: config.Logger,
Expand Down
1 change: 1 addition & 0 deletions pkg/config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ type IPermitConfig interface {
GetDebug() bool
GetContext() *PermitContext
GetLogger() *zap.Logger
// Deprecated: GetProxyFactsViaPDP will be removed in future versions.
GetProxyFactsViaPDP() bool
GetFactsSyncTimeout() *time.Duration
GetFactsSyncTimeoutPolicy() FactsSyncTimeoutPolicy
Expand Down
Loading