refactor(gsplat): remove the compute renderer#8921
Merged
Conversation
Removes the experimental, unmaintained gsplat compute-local renderer (GSPLAT_RENDERER_COMPUTE) to simplify the gsplat pipeline ahead of further refactoring. The hybrid (GPU-sort) and CPU-sort paths are untouched. GSPLAT_RENDERER_COMPUTE and GSPLAT_DEBUG_HEATMAP are kept but deprecated: setting them now logs a Debug.removed warning and falls back to GSPLAT_RENDERER_AUTO / is ignored. They will be removed in a future release. Deletes the compute renderer, its frame pass, dispatch set, tile compositor, and 15 WGSL compute/tile-composite shader chunks; removes the compute branches and compactGpu from GSplatManager. Updates gsplat example control panels to drop the Compute renderer and Heatmap debug options, and the benchmark's compute row.
mvaligursky
added a commit
that referenced
this pull request
Jun 22, 2026
Cleans up dead code left behind by the compute-renderer removal (#8921). - Remove the unused _createTonemapIncludes helper and its two orphaned shader-chunk imports from GSplatRenderer. - Refresh two stale comments that still referenced the compute renderer (class header + setDataSource JSDoc). - Remove the Occluder toggle from the lod-streaming example (control, orange cube, observer wiring); it only enabled sceneDepthMap for the compute rasterizer's manual depth test, which the raster path ignores. Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the experimental, unmaintained gsplat compute-local renderer (
GSPLAT_RENDERER_COMPUTE) to simplify the gsplat pipeline ahead of further renderer/shadow refactoring. The hybrid (GPU-sort) and CPU-sort paths are untouched, and the public constants are kept (deprecated) with graceful fallback, so this is not a breaking change.Changes:
gsplat-compute-local-renderer.js,frame-pass-gsplat-compute-local.js,gsplat-local-dispatch-set.js,gsplat-tile-composite.js, plus 15 WGSL chunks (13compute-gsplat-local-*+ thegsplatTileCompositevert/frag).GSplatManager: removedcompactGpu, theGSPLAT_RENDERER_COMPUTEbranches in_createRenderer/update/prepareForPicking, and the compute-only sort-indirect sentinel. The interval compaction, projector, and radix sort are retained — the hybrid GPU-sort path still uses them.+63 / −3792lines.API Changes (deprecations, non-breaking):
GSPLAT_RENDERER_COMPUTE— retained but@deprecated. Settingscene.gsplat.rendererto it now logs aDebug.removedwarning and falls back toGSPLAT_RENDERER_AUTO.GSPLAT_DEBUG_HEATMAP— retained but@deprecated(it only applied to the compute rasterizer). Settingscene.gsplat.debugto it logs a warning and is ignored.Examples:
vr-lodexample) and the "Heatmap" debug option (3).benchmarkexample.