fix(readme): fix broken image links for proper rendering#499
Conversation
|
Thanks @DevPio, we will review this as soon as possible. |
|
Hi @DevPio, nice to see the
These are just a few examples, but there may be others with similar issues. Could you please check if the fix can address image loading across all samples? |
|
Great, I was trying to find other examples of image breaking but I couldn't find any! I'll make sure it works for all cases. Thanks! |
|
|
|
a lot of issues are because of case-sensitive URLs (readme has For now, let's make sure that if the images load correctly in the sample repository README, they also appear correctly in the sample gallery detail view. |
…nd rehype-raw support
|
@DevPio @Saurabh7019 |
|
I am reopening this; I just saw Luccas' message on LinkedIn, the issue got closed due to an unintended cross repository reference. |
Ok, thanks @Saurabh7019 for you awesome work in managing all this 👍 |
|
@DevPio, Could you please rebase your branch to the latest dev to clean up the commit history and ensure only the relevant changes are included? also, could you please update the |
Sure @adam, I will check it. |
@DevPio, when you get a chance, could you please rebase your branch to |
|
Hi @DevPio, thanks for rebasing, we are almost there.. just a couple more conflicts left in |
|
Hi @DevPio, hope you are well. Just checking in on this PR.. Please let us know if there's anything we can help with. |
|
Hi @Saurabh7019 , I believe all that's left is to finalize the merge, the implementation is ready, I'll need your help to validate, all the issues you pointed out have been fixed. I'll set aside some time to close this merge |
|
Hi @DevPio, there are still a couple of merge conflicts that need resolving before we can finalize. Could you please rebase with latest |
|
hey, we just had a new minor release, which means our dev branch was rebased with main. |
…nd rehype-raw support
|
Finally resolved the conflicts 🎉 @Saurabh7019 Could you please check if everything looks good? I’m available for any further adjustments and sorry for the delay 🙏 |
Saurabh7019
left a comment
There was a problem hiding this comment.
Impressive work, @DevPio. Thanks for this change. All samples are loading fine now.
There are only a few minor issues. Let's fix those before we merge.
…es, no-shadow, quotes, spacing)
|
Merged, Thanks for the fix! |






🎯 Aim
Fix broken image links in the README by updating relative paths to use raw.githubusercontent.com, ensuring proper rendering across environments like SharePoint.
📷 Result
✅ What was done
README.mdto replace broken relative image pathsimages/path dynamically via script🔗 Related issue
Closes: #473