Preserve playback state during scrubbing - #329
Open
ResonantSpiral wants to merge 1 commit into
Open
Conversation
Capture the initial playback state only when a scrub gesture begins. Subsequent slider updates no longer overwrite it after playback has been paused for seeking. Fixes pop-os#325. AI assistance: Codex was used to inspect the seek-state flow, prepare the patch, and run validation. I reviewed and understand the change. Signed-off-by: ResonantSpiral <210097932+ResonantSpiral@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #305.
Detailed reproduction and source diagnosis: #325.
Testing
cargo +1.93.0 check --lockedcargo +1.93.0 test --locked(the project currently defines no unit tests)cargo +1.93.0 build --lockedgit diff --checkcargo +1.93.0 fmt --checkstill reports the existing import-order difference in the unmodifiedbuild.rs. The modifiedsrc/main.rsis not reported by the formatter.AI Assistance
Codex assisted with tracing the seek-state flow, preparing the narrow patch, and running validation. I reviewed and understand the change and can respond to review feedback. The commit message also discloses this assistance.