Skip to content

Preserve playback state during scrubbing - #329

Open
ResonantSpiral wants to merge 1 commit into
pop-os:masterfrom
ResonantSpiral:fix/preserve-playback-state-during-scrub
Open

Preserve playback state during scrubbing#329
ResonantSpiral wants to merge 1 commit into
pop-os:masterfrom
ResonantSpiral:fix/preserve-playback-state-during-scrub

Conversation

@ResonantSpiral

@ResonantSpiral ResonantSpiral commented Aug 26, 2026

Copy link
Copy Markdown

Summary

  • capture the playback state only when a scrub gesture begins
  • preserve the original playing or paused state across repeated slider updates
  • leave click seeking and relative seeking unchanged

Fixes #305.

Detailed reproduction and source diagnosis: #325.

Testing

  • cargo +1.93.0 check --locked
  • cargo +1.93.0 test --locked (the project currently defines no unit tests)
  • cargo +1.93.0 build --locked
  • git diff --check
  • manually verified that scrubbing playing media resumes playback
  • manually verified that scrubbing paused media remains paused
  • manually verified click seeking and relative seeking
  • manually exercised MP4, WebM, FLAC, MP3, and OGG media in normal and condensed layouts

cargo +1.93.0 fmt --check still reports the existing import-order difference in the unmodified build.rs. The modified src/main.rs is not reported by the formatter.

AI Assistance

Codex assisted with tracing the seek-state flow, preparing the narrow patch, and running validation. I reviewed and understand the change and can respond to review feedback. The commit message also discloses this assistance.

  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

Capture the initial playback state only when a scrub gesture begins. Subsequent slider updates no longer overwrite it after playback has been paused for seeking.

Fixes pop-os#325.

AI assistance: Codex was used to inspect the seek-state flow, prepare the patch, and run validation. I reviewed and understand the change.

Signed-off-by: ResonantSpiral <210097932+ResonantSpiral@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Playback pauses while dragging the seek bar

1 participant