Skip to content

Fix breadcrumbs tabs title - #54

Merged
danielguillan merged 2 commits into
mainfrom
danielguillan/fix-breadcrumbs-tabs-title
Jun 26, 2025
Merged

Fix breadcrumbs tabs title#54
danielguillan merged 2 commits into
mainfrom
danielguillan/fix-breadcrumbs-tabs-title

Conversation

@danielguillan

Copy link
Copy Markdown
Contributor

Fixes a bug that caused breadcrumbs to display an incorrect title for the current page.

Before After
screenshot-bhvvKvrJ-000295@2x screenshot-mzLF2RiU-000296@2x

Copilot AI review requested due to automatic review settings June 26, 2025 16:09
@danielguillan
danielguillan requested a review from a team as a code owner June 26, 2025 16:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where breadcrumbs displayed an incorrect title for pages with tabs. The changes include updating the logic for determining the current breadcrumb tab title in Theme.tsx and documenting the fix in the changeset.

  • Updated the condition for filtering index items to use frontMatter in Theme.tsx.
  • Revised the item title computation to incorporate child items when available.
  • Recorded the fix in the changeset file.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
packages/theme/components/layout/root-layout/Theme.tsx Adjusted breadcrumb tab title logic, including new itemTitle setup
.changeset/wild-mangos-pull.md Documented the patch fix for breadcrumbs title issue

Comment thread packages/theme/components/layout/root-layout/Theme.tsx
Comment thread packages/theme/components/layout/root-layout/Theme.tsx

@rezrah rezrah left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@danielguillan
danielguillan merged commit a57f42f into main Jun 26, 2025
8 checks passed
@primer-css primer-css mentioned this pull request Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants