Fix breadcrumbs tabs title - #54
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where breadcrumbs displayed an incorrect title for pages with tabs. The changes include updating the logic for determining the current breadcrumb tab title in Theme.tsx and documenting the fix in the changeset.
- Updated the condition for filtering index items to use frontMatter in Theme.tsx.
- Revised the item title computation to incorporate child items when available.
- Recorded the fix in the changeset file.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/theme/components/layout/root-layout/Theme.tsx | Adjusted breadcrumb tab title logic, including new itemTitle setup |
| .changeset/wild-mangos-pull.md | Documented the patch fix for breadcrumbs title issue |
danielguillan
temporarily deployed
to
github-pages
June 26, 2025 16:11 — with
GitHub Actions
Inactive
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug that caused breadcrumbs to display an incorrect title for the current page.