Skip to content

Fix breadcrumbs tabs title #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielguillan merged 2 commits into from
Jun 26, 2025
Merged

Fix breadcrumbs tabs title #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8a82ab
Fix breadcrumbs tabs title
danielguillan Jun 26, 2025
bd8ca81
Add changeset
danielguillan Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/wild-mangos-pull.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/doctocat-nextjs': patch
---

Fixed a bug that caused breadcrumbs to display an incorrect title for pages with tabs
16 changes: 9 additions & 7 deletions packages/theme/components/layout/root-layout/Theme.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,16 +159,18 @@ export function Theme({pageMap, children}: ThemeProps) {
(index < array.length - 1 &&
nextItem.name === 'index' &&
item.route === nextItem.route &&
// eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
!nextItem.frontMatter?.['tab-label']) ||
(item.name === 'index' &&
// eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
item.frontMatter?.['tab-label'])
!nextItem.frontMatter['tab-label']) ||
(item.name === 'index' && item.frontMatter['tab-label'])
Comment thread
danielguillan marked this conversation as resolved.
)
})
.map((item, index, visibleItems) => {
// eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
const itemTitle = item.frontMatter?.['tab-label'] || item.title
const itemTitle = Array.isArray(item.children)
Comment thread
danielguillan marked this conversation as resolved.
? item.children.find(child => child.name === 'index')?.frontMatter.title ||
item.frontMatter['tab-label'] ||
item.frontMatter.title ||
item.title
: item.frontMatter['tab-label'] || item.frontMatter.title || item.title

const isLastItem = index === visibleItems.length - 1

return (
Expand Down
Loading