Remove underline on Header links - #83
Merged
Merged
Conversation
danielguillan
temporarily deployed
to
github-pages
January 21, 2026 10:20 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes underlines appearing on header links after a @primer/react dependency upgrade by increasing CSS selector specificity. The changes ensure that text-decoration: none is properly applied to all header navigation links.
Changes:
- Increased CSS selector specificity for header site title and navigation links by adding the
aelement selector - Increased CSS selector specificity for dropdown menu links similarly
- Added changeset documenting the fix
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/theme/components/layout/header/Header.module.css | Updated .Header__siteTitle and .Header__link selectors to include a element for higher specificity |
| packages/theme/components/layout/links-dropdown/LinksDropdown.module.css | Updated .link selector to include a element for higher specificity |
| .changeset/old-fishes-suffer.md | Added changeset documenting the removal of underlines from header links |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
danielguillan
temporarily deployed
to
github-pages
January 21, 2026 10:27 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
rezrah
reviewed
Jan 21, 2026
rezrah
reviewed
Jan 21, 2026
danielguillan
temporarily deployed
to
github-pages
January 21, 2026 10:46 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
rezrah
approved these changes
Jan 21, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix underlines appearing on header links (SiteTitle and navigation links) that were introduced as a side effect of upgrading the
@primer/reactdependency. Increases CSS selector specificity to ensuretext-decoration: noneis applied correctly.