Skip to content

Remove underline on Header links #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielguillan merged 4 commits into from
Jan 21, 2026
Merged

Remove underline on Header links #83

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e9be8be
Remove underline on Header links
danielguillan Jan 21, 2026
3b5fd59
Add changeset
danielguillan Jan 21, 2026
e3cdd6d
Simplify selector
danielguillan Jan 21, 2026
c8ee4eb
Use important
danielguillan Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/old-fishes-suffer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/doctocat-nextjs': patch
---

Remove underlines from header links
8 changes: 5 additions & 3 deletions packages/theme/components/layout/header/Header.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,8 @@
}
}

.Header__siteTitle {
.Header a.Header__siteTitle,
Comment thread
rezrah marked this conversation as resolved.
Outdated
Comment thread
danielguillan marked this conversation as resolved.
Outdated
.Header a.Header__siteTitle:hover {
display: flex;
gap: var(--base-size-8);
align-items: center;
Expand All @@ -123,15 +124,16 @@
gap: var(--base-size-2);
}

.Header__link {
.Header a.Header__link,
.Header a.Header__link:hover {
text-decoration: none;
font-size: var(--base-font-size-16);
font-weight: var(--base-font-weight-500);
padding: var(--base-size-6) var(--base-size-12);
border-radius: var(--brand-borderRadius-small);
}

.Header__link:hover {
.Header a.Header__link:hover {
background-color: var(--brand-color-canvas-subtle);
}
Comment thread
danielguillan marked this conversation as resolved.
Outdated

Expand Down
7 changes: 4 additions & 3 deletions packages/theme/components/layout/links-dropdown/LinksDropdown.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,22 +92,23 @@
border-radius: var(--brand-borderRadius-medium);
}

.link:focus-visible {
.dropdown a.link:focus-visible {
position: relative;
outline: var(--base-size-4) solid var(--brand-color-focus);
border-radius: var(--brand-borderRadius-small);
z-index: 1;
}

.link {
.dropdown a.link,
.dropdown a.link:hover {
display: block;
padding: var(--base-size-6) var(--base-size-8);
text-decoration: none;
color: var(--brand-color-text-default);
cursor: pointer;
}

.link:hover {
.dropdown a.link:hover {
background-color: var(--brand-color-canvas-subtle);
}
Comment thread
danielguillan marked this conversation as resolved.
Outdated

Expand Down
Loading