518 added additional relationships to Event page timelines#849
Open
518 added additional relationships to Event page timelines#849
Conversation
kamerynB
force-pushed
the
518-add-timelines-to-events
branch
from
baf6362 to
13990f3
Compare
kamerynB
commented
Feb 27, 2026
| searchTag: 'lux:eventSetsAboutTime', | ||
| tab: 'collections', | ||
| jsonSearchTerm: 'publishedDate,createdDate', | ||
| jsonSearchTerm: 'publishedDate,createdDate', // this should be correct |
Contributor
Author
There was a problem hiding this comment.
Remove this comment.
kamerynB
force-pushed
the
518-add-timelines-to-events
branch
2 times, most recently
from
aceae6a to
86f86c7
Compare
| @@ -101,9 +101,29 @@ export const relatedAccordions: IHalLinks = { | |||
|
|
|||
| // Used for rendering timelines | |||
| export const timelines: IHalLinks = { | |||
Contributor
There was a problem hiding this comment.
need to add an entry for itemProductionDate which will be added in the middle tier
| itemIncludedDate: { | ||
| searchTag: 'lux:eventItemIncludedTime', | ||
| tab: 'objects', | ||
| jsonSearchTerm: 'publishedDate,createdDate', |
Contributor
There was a problem hiding this comment.
none of the timeline entries need a jsonSearchTerm. These should be removed
Contributor
|
@kamerynB timeline.ts facetNameMap is using the facets to give a name to each timeline label. But it is possible that multiple HAL links share the same facet. I think you'll have to change it to map by the HAL link name instead. |
kamerynB
force-pushed
the
518-add-timelines-to-events
branch
from
2a3245e to
b7b9d03
Compare
kamerynB
force-pushed
the
518-add-timelines-to-events
branch
from
b7b9d03 to
8fd6d5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.