Skip to content

518 added additional relationships to Event page timelines #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kamerynB wants to merge 4 commits into
base: main
Choose a base branch
from
+37 −14
Open

518 added additional relationships to Event page timelines #849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
302432a
release branch for v1.68.0
Apr 13, 2026
2deedb4
518 added additional relationships to Event page timelines
Feb 20, 2026
68f4cfc
565 changed works caused by to works generated by
Feb 27, 2026
8fd6d5f
518 fixed config
Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion client/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,17 @@

All notable changes to this project will be documented in this file.

## v1.67.0 - Unreleased
## v1.68.0 - Unreleased

### Added

### Changed

### Fixed

### Removed

## v1.67.0 - 2026-4-13

### Added

Expand Down Expand Up @@ -125,11 +135,13 @@ All notable changes to this project will be documented in this file.
### Added

- Added namespace to LUX ID input in the advanced search ([#714](https://github.com/project-lux/lux-frontend/issues/714)).
- Added objects included, works about, works caused by, and sets caused by to timelines on Event pages ([#518](https://github.com/project-lux/lux-frontend/issues/518)).

### Changed

- Changed advanced search LUX IDs to be editable ([#827](https://github.com/project-lux/lux-frontend/issues/827)).
- Changed the styling of About sections on People and Groups, Places, Concepts, and Events pages ([#670](https://github.com/project-lux/lux-frontend/issues/670)).
- Changed 'Works Caused By' to 'Works Generated By' ([#565](https://github.com/project-lux/lux-frontend/issues/565)).

### Fixed

Expand Down
27 changes: 23 additions & 4 deletions client/src/config/eventSearchTags.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ export const relatedEntites: IHalLinks = {
searchTag: 'lux:eventWorksAbout',
tab: 'works',
},
worksCausedBy: {
title: 'Works Caused By',
worksGeneratedBy: {
title: 'Works Generated By',
searchTag: 'lux:eventCausedWorks',
tab: 'works',
},
Expand Down Expand Up @@ -101,9 +101,28 @@ export const relatedAccordions: IHalLinks = {

// Used for rendering timelines
export const timelines: IHalLinks = {
Copy link
Copy Markdown
Contributor

@clarkepeterf clarkepeterf Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to add an entry for itemProductionDate which will be added in the middle tier

Copy link
Copy Markdown
Contributor Author

@kamerynB kamerynB Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

itemIncludedDate: {
searchTag: 'lux:eventItemIncludedTime',
tab: 'objects',
},
itemProductionDate: {
searchTag: 'lux:eventItemMadeTime',
tab: 'objects',
},
workCreationOrPublicationDate: {
searchTag: 'lux:eventWorksAboutTime',
tab: 'works',
},
workCausedBy: {
searchTag: 'lux:eventWorksCausedByTime',
tab: 'works',
},
setCausedBy: {
searchTag: 'lux:eventSetsCausedByTime',
tab: 'collections',
},
setAboutDate: {
searchTag: 'lux:eventSetAboutTime',
searchTag: 'lux:eventSetsAboutTime',
tab: 'collections',
jsonSearchTerm: 'publishedDate,createdDate',
},
}
1 change: 0 additions & 1 deletion client/src/features/timeline/Graph.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,6 @@ const Graph: React.FC<IProps> = ({
if (!relationshipsToShowInLegend.includes(facetKey)) {
return null
}

let defaultLegend = 'focused'
if (isNull(activeLegend)) {
defaultLegend = 'focused'
Expand Down
9 changes: 1 addition & 8 deletions client/src/features/timeline/ListRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import theme from '../../styles/theme'
import StyledDd from '../../styles/shared/DescriptionDetail'
import StyledDt from '../../styles/shared/DescriptionTerm'
import StyledResponsiveCol from '../../styles/shared/ResponsiveCol'
import { facetNameMap } from '../../config/timeline'

const HoverableRow = styled(Row)`
&:hover {
Expand All @@ -30,14 +31,6 @@ const ListRow: React.FC<{
year: string
searchTag: string
}> = ({ searchTags, data, year, searchTag }) => {
const facetNameMap: Map<string, string> = new Map([
['itemProductionDate', 'Objects Produced'],
['itemEncounteredDate', 'Objects Encountered'],
['workCreationDate', 'Works Created'],
['workPublicationDate', 'Works Published'],
['workCreationOrPublicationDate', 'Works About'],
])

const { tab } = searchTags[searchTag]
const { searchParams, totalItems } = data[year][
searchTag
Expand Down