test(ui): preload lazy survey chunk to fix flaky feedback tests

[alejandrobailo]

Context

ui/components/survey/feedback-survey.test.tsx was flaky under full-suite load: the component lazy-loads runtime-feedback-survey via React.lazy, and each test's vi.resetModules() forces the whole chunk graph (posthog-js mock, Radix popover, lucide, zustand store) to re-evaluate inside the findBy* polling window. On a loaded machine that evaluation can exceed Testing Library's default 1s timeout, so the first test in the file failed intermittently during pnpm run test while passing in isolation.

Description

• renderSurvey now pre-awaits import("./runtime-feedback-survey") before rendering, so the lazy chunk is already in the module registry and React.lazy resolves in a microtask — module evaluation no longer races the 1s findBy* window.
• No timeout tuning: default query timeouts are kept, so a genuine rendering regression still fails fast.
• The three guard tests that assert the PostHog surface is never touched (empty runtime config, PostHog disabled, not Cloud) opt out via renderSurvey({ preloadRuntime: false }), keeping their mocks.moduleLoaded never-called assertions meaningful — they still prove OSS never evaluates posthog-js.

Steps to review

1. In ui/components/survey/feedback-survey.test.tsx, check the renderSurvey helper: the pre-import runs before render() and defaults to on.
2. Verify the three opt-out call sites are exactly the tests asserting mocks.moduleLoaded was never called.
3. Run cd ui && pnpm run test a few times — verified locally with three consecutive green full-suite runs (421 files / 2911 tests), plus the file in isolation (21/21).

Checklist

Community Checklist

• This feature/issue is listed in the open issues or roadmap.prowler.com
• Is it assigned to me, if not, request it via the open issues or Prowler Community Slack
• I have reviewed the open pull requests and confirmed there is no existing PR that implements the same outcome

• Review if the code is being covered by tests.
• Review if code is being documented following this specification https://github.com/google/styleguide/blob/gh-pages/pyguide.md#38-comments-and-docstrings
• Review if backport is needed.
• Review if is needed to change the README.md
• Ensure a changelog fragment is added under prowler/changelog.d/, if applicable.

SDK/CLI

• Are there new checks included in this PR? No

UI

• All issue/task requirements work as expected on the UI
• If this PR adds or updates npm dependencies, include package-health evidence (maintenance, popularity, known vulnerabilities, license, release age) and explain why existing/native alternatives are insufficient.
• Screenshots/Video of the functionality flow (if applicable) - Mobile (X < 640px)
• Screenshots/Video of the functionality flow (if applicable) - Table (640px > X < 1024px)
• Screenshots/Video of the functionality flow (if applicable) - Desktop (X > 1024px)
• Ensure a changelog fragment is added under ui/changelog.d/, if applicable. (Not applicable: test-only change.)

API

No API changes.

MCP Server

No MCP Server changes.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Summary by CodeRabbit

• Tests
  • Improved feedback survey test setup by preloading the survey component by default.
  • Added coverage for scenarios where the analytics service must not be loaded.

[github-actions]

✅ No Conflicts

No conflict markers, and the branch merges cleanly into its base.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 76570a6b-faf5-4cc8-9265-6c6cf842ed33

📥 Commits

Reviewing files that changed from the base of the PR and between fd555e2 and c5d7d2e.

📒 Files selected for processing (1)

• ui/components/survey/feedback-survey.test.tsx

---

📝 Walkthrough

Walkthrough

The feedback survey test helper now optionally preloads the runtime chunk. Preloading is enabled by default. Tests that verify PostHog is not loaded disable preloading.

Changes

Survey runtime tests

Layer / File(s)	Summary
Runtime preload control ui/components/survey/feedback-survey.test.tsx	renderSurvey conditionally imports the runtime chunk before rendering. Tests that assert no PostHog access set preloadRuntime: false.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• prowler-cloud/prowler#12380: Makes the same renderSurvey preload changes and disables preloading for PostHog non-loading tests.

Suggested reviewers: adriiiprodri

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the test-only preload change and its purpose of fixing flaky feedback survey tests.
Description check	✅ Passed	The description includes context, implementation details, review steps, test evidence, checklist status, and applicable scope information.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/flaky-feedback-survey-test

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

🔒 Container Security Scan

Image: prowler-ui:d26cf81
Last scan: 2026-08-07 07:37:51 UTC

✅ No Vulnerabilities Detected

The container image passed all security checks. No known CVEs were found.

📋 Resources:

• Download full report (see artifacts)
• View in Security tab
• Scanned with Trivy

[github-actions]

🔎 Container Security Scan (Grype)

Image: prowler-ui:d26cf81
Last scan: 2026-08-07 07:39:00 UTC

✅ Nothing Blocking

No findings at critical or high severity.

---

📋 Resources:

• Download full report (see artifacts)
• View in Security tab
• Scanned with Grype, alongside Trivy

[prowler-bot]

💚 All backports created successfully

Status	Branch	Result
✅	v5.38

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details