Skip to content

test(ui): preload lazy survey chunk to fix flaky feedback tests #12387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alejandrobailo merged 1 commit into from
Aug 7, 2026
Merged

test(ui): preload lazy survey chunk to fix flaky feedback tests #12387

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions ui/components/survey/feedback-survey.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,11 @@ const provideSurveys = (surveys: Survey[]): void => {
});
};

const renderSurvey = async () => {
// Pre-evaluating the lazy chunk keeps findBy* queries from racing module
// evaluation under full-suite load; guard tests that assert the chunk is never
// touched opt out via preloadRuntime: false.
const renderSurvey = async ({ preloadRuntime = true } = {}) => {
if (preloadRuntime) await import("./runtime-feedback-survey");
const { FeedbackSurvey } = await import("./feedback-survey");
return render(<FeedbackSurvey />);
};
Expand Down Expand Up @@ -475,7 +479,7 @@ describe("FeedbackSurvey", () => {
});

// When
const view = await renderSurvey();
const view = await renderSurvey({ preloadRuntime: false });

// Then - no init, no survey fetch, nothing rendered
expect(mocks.init).not.toHaveBeenCalled();
Expand All @@ -495,7 +499,7 @@ describe("FeedbackSurvey", () => {
});

// When
const view = await renderSurvey();
const view = await renderSurvey({ preloadRuntime: false });

// Then
expect(view.container).toBeEmptyDOMElement();
Expand All @@ -515,7 +519,7 @@ describe("FeedbackSurvey", () => {
provideSurveys([SURVEY_FIXTURE]);

// When
const view = await renderSurvey();
const view = await renderSurvey({ preloadRuntime: false });

// Then - no init, no trigger, no survey fetch, no capture, regardless of config
expect(view.container).toBeEmptyDOMElement();
Expand Down
Loading