qgisapp: Fix crash when opening a 3D view with an active elevation profile#66434
Open
ptitjano wants to merge 2 commits into
Open
qgisapp: Fix crash when opening a 3D view with an active elevation profile#66434ptitjano wants to merge 2 commits into
ptitjano wants to merge 2 commits into
Conversation
The `sizeChanged` lambda captures `this`, so it reads mMarkerMaterial at emission time. But it can become null if the material has been deleted in the meantime. This is fixed by capturing the material by value instead.
…ofile When a 3D map view is created, the profile curves are drawn in it, if the "show profile in 3D views" option is activated. This is achieved by calling `profileWidget->updateCurveIn3D()` in `QgisApp::createNew3DMapCanvasDock()`. However, the 3D canvas map settings have not been initialized it and this results in a crash. This is fixed by moving the `profileWidget->updateCurveIn3D()` calls after the canvas widget map settings initialization.
ptitjano
added
3D
nyalldawson
approved these changes
Jun 10, 2026
Contributor
|
@ptitjano master only, or 3.44 material ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
From the main commit message
AI tool usage
No AI Tool used