Skip to content

qgisapp: Fix crash when opening a 3D view with an active elevation profile #66434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ptitjano wants to merge 2 commits into
base: master
Choose a base branch
from
+6 −2
Open

qgisapp: Fix crash when opening a 3D view with an active elevation profile #66434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b989ac0
qgsrubberband3d: Fix potential crash in updateMarkerMaterial
ptitjano Jun 10, 2026
58c1a18
qgisapp: Fix crash when opening a 3D view with an active elevation pr…
ptitjano Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/3d/qgsrubberband3d.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,7 +496,7 @@ void QgsRubberBand3D::updateMarkerMaterial()
mMarkerMaterial = new QgsPoint3DBillboardMaterial();
mMarkerEntity->addComponent( mMarkerMaterial );
//TODO: QgsAbstract3DEngine::sizeChanged should have const QSize &size param
QObject::connect( mEngine, &QgsAbstract3DEngine::sizeChanged, mMarkerMaterial, [this] { mMarkerMaterial->setViewportSize( mEngine->size() ); } );
QObject::connect( mEngine, &QgsAbstract3DEngine::sizeChanged, mMarkerMaterial, [material = mMarkerMaterial, engine = mEngine] { material->setViewportSize( engine->size() ); } );
}

mMarkerMaterial->setTexture2DFromSymbol( mMarkerSymbol.get(), Qgs3DRenderContext::fromMapSettings( mMapSettings ) );
Expand Down
6 changes: 5 additions & 1 deletion src/app/qgisapp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13452,7 +13452,6 @@ Qgs3DMapCanvasWidget *QgisApp::createNew3DMapCanvasDock( const QString &name, bo
connect( profileWidget, &QgsElevationProfileWidget::profileDataChanged, widget, &Qgs3DMapCanvasWidget::setProfileData );
connect( profileWidget, &QgsElevationProfileWidget::profileDataRemoved, widget, &Qgs3DMapCanvasWidget::removeProfileData );
connect( profileWidget, &QgsElevationProfileWidget::profileCursorMoved, widget, &Qgs3DMapCanvasWidget::updateProfileCursorPosition );
profileWidget->updateCurveIn3D();
}

return widget;
Expand Down Expand Up @@ -13650,6 +13649,11 @@ Qgs3DMapCanvas *QgisApp::createNewMapCanvas3D( const QString &name, Qgis::SceneM

canvasWidget->setMapSettings( map );

for ( QgsElevationProfileWidget *profileWidget : std::as_const( mElevationProfileWidgets ) )
{
profileWidget->updateCurveIn3D();
}

// configure initial position of the camera (it should approximate the current 2D view)
switch ( sceneMode )
{
Expand Down
Loading