6.12/iob/topic/rpi imx283 overlay

[kbingham]

Add support for the IMX283 on Raspberry Pi platforms. This includes the OneInchEye open source camera.

[kbingham]

And of course I now realise adding the module to 'all configs' is pointless as this is currently only supported as a 4 lane sensor.

But I see 'Compute Module (1, 3, 4, or 5) has 4 lanes, and perhaps so does a pi02w?
So I'm not actually sure which configs should or shouldn't have the module....

[kbingham]

Any changes required from me here ?

Or is it ok to keep the module enabled in all configs ? (Are there any variants that only have a 2 lane device associated ?)

[6by9]

Any changes required from me here ?

Or is it ok to keep the module enabled in all configs ? (Are there any variants that only have a 2 lane device associated ?)

With the 360MHz link frequency, all devices with 4 data lanes could potentially run this sensor. That would include CM1, CM3, CM4, Pi5, and CM5. (Pi0 and Pi02 have the 22 pin connector due to space constraints, but only 2 lanes are connected).

The only defconfig that therefore can't really make use of it would be bcm2709_defconfig (Pi2), but I'd be tempted to leave it there for consistency.

LGTM.

[pelwell]

Checkpatch is still complaining about the missing newline at the end of imx283-overlay.dts.

[kbingham]

Checkpatch is still complaining about the missing newline at the end of imx283-overlay.dts.

Aha, I see it - I'll fix that up now.

[pelwell]

If you comment when that's done I'll kick off the builds again, then get it merged.

[kbingham]

repushed..

Local checkpatch reports the following, but I don't think that can/should be helped here, as none of the other fragments put an SPDX header in.... and I don't think changing MAINTAINERS is appropriate here.

kbingham@Monstersaurus:~/iob/libcamera/raspberrypi/sources/linux$ ./scripts/checkpatch.pl -g HEAD^^..
--------------------------------------------------------------------------
Commit 3ed0713dc587 ("dtoverlays: Add overlay for the Sony IMX283 Camera")
--------------------------------------------------------------------------
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#74: 
new file mode 100644

WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
#177: FILE: arch/arm/boot/dts/overlays/imx283.dtsi:1:
+// Fragment that configures a Sony IMX283

total: 0 errors, 2 warnings, 154 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 3ed0713dc587 ("dtoverlays: Add overlay for the Sony IMX283 Camera") has style problems, please review.
-------------------------------------------------------------------
Commit 7711895a2ff0 ("defconfigs: Add IMX283 to all Pi defconfigs")
-------------------------------------------------------------------
total: 0 errors, 0 warnings, 42 lines checked

Commit 7711895a2ff0 ("defconfigs: Add IMX283 to all Pi defconfigs") has no obvious style problems and is ready for submission.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

[pelwell]

Yes, I'm fine with the remaining warnings.