firmware: rp1: Rename to rp1-fw to avoid module name collision#6879
Merged
Conversation
There is already the driver in drivers/mfd/rp1.ko, so having drivers/firmware/rp1.ko can cause issues when using modinfo and similar, and we can get errors with "Module rp1 is already loaded" when trying to load it. Rename the module so that the name is unique. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Jun 3, 2025
kernel: overlays: sc16is75x: Add generic SPI overlay See: raspberrypi/linux#6865 kernel: add mira220 image sensor See: raspberrypi/linux#6717 kernel: defconfigs: Enable WATCHDOG_SYSFS See: raspberrypi/linux#6875 kernel: drivers: pci: hailo: Better lock handling when calling find_vdma() See: raspberrypi/linux#6868 kernel: drivers: media: imx500: Enable sensor temperature monitoring See: raspberrypi/linux#6877 kernel: firmware: rp1: Rename to rp1-fw to avoid module name collision See: raspberrypi/linux#6879 kernel: Candidate fixes for camera sync issues See: raspberrypi/linux#6863
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Jun 3, 2025
kernel: overlays: sc16is75x: Add generic SPI overlay See: raspberrypi/linux#6865 kernel: add mira220 image sensor See: raspberrypi/linux#6717 kernel: defconfigs: Enable WATCHDOG_SYSFS See: raspberrypi/linux#6875 kernel: drivers: pci: hailo: Better lock handling when calling find_vdma() See: raspberrypi/linux#6868 kernel: drivers: media: imx500: Enable sensor temperature monitoring See: raspberrypi/linux#6877 kernel: firmware: rp1: Rename to rp1-fw to avoid module name collision See: raspberrypi/linux#6879 kernel: Candidate fixes for camera sync issues See: raspberrypi/linux#6863
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is already the driver in drivers/mfd/rp1.ko, so having drivers/firmware/rp1.ko can cause issues when using modinfo and similar, and we can get errors with "Module rp1 is already loaded" when trying to load it.
Rename the module so that the name is unique.
Appears to be the cause of #6878. drm-rp1-dpi now needs rp1-pio, which needs rp1's firmware driver. The module dependencies don't load rp1's firmware driver as it believes
rp1is already loaded, except it's the mfd one. Trying to load it manually throws an error that the module is loaded.modinfo is confused too
so is it the firmware driver or the mfd one?!
Keeping names unique makes life simpler.