Fix FixOpenAI for repeated well-known types, remove Taskfile - #38
Merged
Merged
Conversation
FixOpenAI silently skipped string-encoded well-known types (Value, ListValue, Struct) when they appeared as elements of repeated fields. The repeated field handler only checked for map[string]any elements, missing the string->JSON conversion entirely. Also remove Taskfile.yml/taskw/.taskversion -- everything runs through just now. Port remaining useful targets (test-cover, conformancetest, integrationtest, install, lint, fmt) to the justfile. Closes #34
Literal adaptation of the JSON from the bug report: repeated message containing a map field that FixOpenAI previously failed to convert.
The conformance/integration Bazel targets are tagged manual, so bazelisk test //... never ran them. Add a separate step that explicitly invokes them with the API key secrets passed through. Skipped on fork PRs where secrets aren't available.
The if-condition already skips fork PRs, but add an explicit runtime check for empty secrets as a second safety net. GitHub itself never populates secrets for fork workflows, so this is triple-layered.
Add --test_output=all --test_arg=-test.v so Bazel prints every test function name instead of just package-level PASS/FAIL.
Add --test_summary=detailed and --test_arg=-test.v to .bazelrc so individual test cases show up in every bazelisk test run, locally and in CI, without per-command flags.
birdayz
force-pushed
the
jb/fix-openai-repeated-wkt-and-remove-taskfile
branch
from
March 13, 2026 11:14
c76fd85 to
5648fad
Compare
Show individual test case names in CI output while keeping short summary locally.
rules_go generates test.xml (JUnit) automatically, which is what --test_summary=detailed parses. The -test.v flag only controls raw stdout verbosity -- irrelevant when --test_output=errors suppresses it anyway.
rockwotj
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix
FixOpenAIto handle well-known types inside repeated fields. RemoveTaskfile.yml/taskwin favor ofjust.Why
FixOpenAIsilently skipped string-encoded well-known types (Value,ListValue,Struct) when they appeared as elements of repeated fields. The repeated field handler only checked formap[string]anyelements (regular nested messages), so the string-to-JSON conversion for WKTs never fired. Reported in #34.The Taskfile was redundant -- all build/test commands now go through
justafter the Bazel migration.Implementation details
Bug fix (
pkg/runtime/fix.go): TheIsList()branch now switches on the message full name before falling through to the default recursion. For WKT types, it deserializes string elements back to proper JSON -- same logic that already existed for singular fields.Taskfile removal: Ported remaining useful targets (
test-cover,conformancetest,integrationtest,install,lint,fmt) to the justfile. Updated all references in CLAUDE.md, README.md, integration/example READMEs, and the golden test error message.References
Closes #34