Fix scountovf read behavior in M-mode according to RISC-V Privileged SpecFix scountovf read behavior in M-mode according to RISC-V Privileged …#2243
Open
chillakalyan wants to merge 1 commit intoriscv-software-src:masterfrom
Conversation
Collaborator
|
Sounds right to me. Please fix the merge conflict, then force-push over the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the RISC-V Privileged Specification, scountovf bits should
always be readable in M-mode.
The current implementation masks the value using mcounteren (and
hcounteren in VS-mode), which incorrectly restricts visibility in M-mode.
This patch updates scountovf_csr_t::read() so that counteren masking
is applied only when the current privilege mode is not M-mode.