Add parameter to allow controllers with inactive hardware components#2501
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2501 +/- ##
==========================================
+ Coverage 89.32% 89.42% +0.10%
==========================================
Files 147 147
Lines 16589 16637 +48
Branches 1396 1400 +4
==========================================
+ Hits 14818 14878 +60
+ Misses 1234 1220 -14
- Partials 537 539 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
MarqRazz
left a comment
There was a problem hiding this comment.
Thanks for the quick turn around @saikishor! I will try to test it out on my hardware when I get a chance.
Do we want to add any deprecation warnings to this or are we going to support this feature going forward?
@MarqRazz yes, there will be a warning printed that it is not the recommended way to do it. Regarding the deprecation warning, I think we should do it once we have the configuration interfaces ready as it is the point when we will start to drop support to this. As we don't want to remove everything in a single release version. What do you think? |
Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Co-authored-by: Marq Rasmussen <marq.razz@gmail.com>
|
@christophfroehlich how does it look now? |
Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
Gives #2484 a possibility to fix with a parameter
In the 27th August, 2025 PMC meeting, it has been decided to maintain the current behavior, but have an way to the old behavior using a controller_manager parameter. As the main fix is regarding the safety concerns, multiple attendees agreed to keep the behavior, but add a parameter to opt-out of it