Skip to content

fix typo in state and reference export methods#3347

Merged
bmagyar merged 1 commit into
ros-controls:masterfrom
christianrauch:fix_typo
May 27, 2026
Merged

fix typo in state and reference export methods#3347
bmagyar merged 1 commit into
ros-controls:masterfrom
christianrauch:fix_typo

Conversation

@christianrauch

@christianrauch christianrauch commented May 25, 2026

Copy link
Copy Markdown
Contributor

Description

The controller_manager may report something like

Controller '%s' is chainable, but does not export any state or reference interfaces. Did you override the on_export_method() correctly?

But the method on_export_method() does not exist. Since it tests for export_state_interfaces() and export_reference_interfaces(), I assume this is supposed to be on_export_state_interfaces_list() and on_export_reference_interfaces_list().

Is this user-facing behavior change?

Yes. It changes the reported string.

Did you use Generative AI?

No.

Additional Information

TODOs

To send us a pull request, please:

  • Fork the repository.
  • Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change.
  • Ensure local tests pass. (colcon test and pre-commit run (requires you to install pre-commit by pip3 install pre-commit)
  • Commit to your fork using clear commit messages.
  • Send a pull request, answering any default questions in the pull request interface.
  • Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.

@christianrauch christianrauch marked this pull request as ready for review May 25, 2026 12:05
@bmagyar bmagyar merged commit 6612e53 into ros-controls:master May 27, 2026
21 of 29 checks passed
@bmagyar bmagyar added backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted. labels May 27, 2026
@christianrauch christianrauch deleted the fix_typo branch May 27, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants