fix typo in state and reference export methods#3347
Merged
Conversation
saikishor
approved these changes
May 25, 2026
bmagyar
approved these changes
May 27, 2026
This was referenced May 27, 2026
christophfroehlich
pushed a commit
that referenced
this pull request
May 27, 2026
christophfroehlich
pushed a commit
that referenced
this pull request
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
controller_managermay report something likeBut the method
on_export_method()does not exist. Since it tests forexport_state_interfaces()andexport_reference_interfaces(), I assume this is supposed to beon_export_state_interfaces_list()andon_export_reference_interfaces_list().Is this user-facing behavior change?
Yes. It changes the reported string.
Did you use Generative AI?
No.
Additional Information
TODOs
To send us a pull request, please:
colcon testandpre-commit run(requires you to install pre-commit bypip3 install pre-commit)