-
Notifications
You must be signed in to change notification settings - Fork 62
feat: removed visualizers and updated build. #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| # Using Other Visualizations. | ||
|
|
||
| To use another visualizer, git clone one of the `rosflight_viz_*` repos from the ROSflight organization on GitHub into this repo and build as normal. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is nitpicky. Could we maybe move this READme to the top level rosflight_ros_pkgs readme? Otherwise I could see people having a hard time finding it. We should also tell them exactly which directory to clone the |
||
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do we make sure users get these deps when they are using Gazebo classic? I briefly glanced at the rosflight_viz_gazebo_classic, but didn't see a fix (just a warning). These tags are needed to successfully install deps for GZ classic when doing the "rosdep install ..." command.