feat: removed visualizers and updated build.#258
Open
iandareid wants to merge 2 commits into
Open
Conversation
JMoore5353
reviewed
Jun 12, 2026
JMoore5353
left a comment
JMoore5353
left a comment
Contributor
There was a problem hiding this comment.
I think this will be a great fix, and will help reduce some of the build times.
| <depend>rclcpp</depend> | ||
| <depend>rclpy</depend> | ||
|
|
||
| <depend condition="$ROS_DISTRO == 'humble'">gazebo_dev</depend> |
Contributor
There was a problem hiding this comment.
How do we make sure users get these deps when they are using Gazebo classic? I briefly glanced at the rosflight_viz_gazebo_classic, but didn't see a fix (just a warning). These tags are needed to successfully install deps for GZ classic when doing the "rosdep install ..." command.
| @@ -0,0 +1,3 @@ | |||
| # Using Other Visualizations. | |||
|
|
|||
| To use another visualizer, git clone one of the `rosflight_viz_*` repos from the ROSflight organization on GitHub into this repo and build as normal. | |||
Contributor
There was a problem hiding this comment.
This is nitpicky. Could we maybe move this READme to the top level rosflight_ros_pkgs readme? Otherwise I could see people having a hard time finding it.
We should also tell them exactly which directory to clone the rosflight_viz_* packages into, to avoid confusion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have separated the visualizers from the rest of the repo. They are now 3 seperate repos in the rosflight org. These are selectively cloned by the user based on their needs. Now the standalone is the only visualizer that ships with rosflight.